RE: [PATCH v2 5/9] Drivers: hv: vmbus: Support >64 VPs for a fully enlightened TDX/SNP VM

Dexuan Cui
2023-08-21T18:17:47Z

> From: Michael Kelley (LINUX) <mikelley@microsoft.com>
> Sent: Monday, August 21, 2023 7:30 AM
> [...]
> From: Dexuan Cui <decui@microsoft.com> Sent: Sunday, August 20, 2023
> 1:27 PM
> > [...]
> > When such a VM has more than 64 VPs, if the hyperv_pcpu_input_arg is
> > not NULL, hv_common_cpu_init() -> set_memory_decrypted() -> ... ->
> > cpa_flush() -> on_each_cpu() -> ... -> hv_send_ipi_mask() -> ... ->
> > __send_ipi_mask_ex() tries to call hv_do_fast_hypercall16() with the

s/hv_do_rep_hypercall/hv_do_rep_hypercall

> Actually, it tries to call hv_do_rep_hypercall(). Using the memory-based
> hyperv_pcpu_input_arg with a "fast" hypercall doesn't make sense.

Thanks for spotting the mistake!

> > hyperv_pcpu_input_arg as the hypercall input page, which must be a
> > decrypted page in such a VM, but the page is still encrypted at this
> > point, and a fatal fault is triggered.
> >
> Modulo the minor correction in the commit message,
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

Thanks!