From: chengming.zhou@linux.dev
To: axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de, bvanassche@acm.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
zhouchengming@bytedance.com
Subject: [PATCH 3/4] blk-mq: delete superfluous check in iterate callback
Date: Mon, 21 Aug 2023 15:35:27 +0800 [thread overview]
Message-ID: <20230821073528.3469210-4-chengming.zhou@linux.dev> (raw)
In-Reply-To: <20230821073528.3469210-1-chengming.zhou@linux.dev>
From: Chengming Zhou <zhouchengming@bytedance.com>
The blk_mq_queue_tag_busy_iter() already has BT_TAG_ITER_STARTED flag
filter set, only started requests will be iterated over.
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
block/blk-mq.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index f14b8669ac69..0b03963e0854 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1496,19 +1496,15 @@ EXPORT_SYMBOL(blk_mq_delay_kick_requeue_list);
static bool blk_mq_rq_inflight(struct request *rq, void *priv)
{
+ bool *busy = priv;
+
/*
* If we find a request that isn't idle we know the queue is busy
* as it's checked in the iter.
* Return false to stop the iteration.
*/
- if (blk_mq_request_started(rq)) {
- bool *busy = priv;
-
- *busy = true;
- return false;
- }
-
- return true;
+ *busy = true;
+ return false;
}
bool blk_mq_queue_inflight(struct request_queue *q)
--
2.41.0
next prev parent reply other threads:[~2023-08-21 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 7:35 [PATCH 0/4] blk-mq-tag: remove bt_for_each() chengming.zhou
2023-08-21 7:35 ` [PATCH 1/4] blk-mq-tag: support queue filter in bt_tags_iter() chengming.zhou
2023-08-21 19:58 ` Bart Van Assche
2023-08-22 2:21 ` Chengming Zhou
2023-08-21 7:35 ` [PATCH 2/4] blk-mq-tag: remove bt_for_each() chengming.zhou
2023-08-21 21:26 ` Bart Van Assche
2023-08-22 2:27 ` Chengming Zhou
2023-08-21 7:35 ` chengming.zhou [this message]
2023-08-21 21:29 ` [PATCH 3/4] blk-mq: delete superfluous check in iterate callback Bart Van Assche
2023-08-21 7:35 ` [PATCH 4/4] blk-mq-tag: update or fix functions documentation chengming.zhou
2023-08-21 21:32 ` Bart Van Assche
2023-08-22 2:36 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821073528.3469210-4-chengming.zhou@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox