Re: [PATCH v1 2/5] ASoC: dt-bindings: Add schema for "allwinner,sun20i-d1-codec-analog"

Maxim Kiselev
2023-08-23T16:13:49Z

пн, 21 авг. 2023 г. в 19:47, Rob Herring <robh@kernel.org>:
>
> On Sat, Aug 05, 2023 at 09:05:02PM +0300, Maksim Kiselev wrote:
> > Add a DT schema to describe the analog part of the Allwinner D1/T113s
> > internal audio codec.
> >
> > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>
> > ---
> > .../allwinner,sun20i-d1-codec-analog.yaml | 33 +++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun20i-d1-codec-analog.yaml
>
> Looks the same as allwinner,sun8i-a23-codec-analog.yaml. Why can't you
> use that?
>
Hmm. You're right. But let me explain my decision :)
When I added a new file, I assumed that since this is a separate driver,
then the binding should be in a separate file.

As an example, I looked at the sun50i-a64-codec-analog.yaml binding.
It is mostly the same as sun8i-a23-codec-analog.yaml too.

So I really don't know which approach is better. If you advise me
just add a new compatible sting to sun8i-a23-codec-analog.yaml,
then I'll gladly do it in the next version.

Cheers,
Maksim