* [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
@ 2023-08-16 17:19 Uwe Kleine-König
2023-08-16 18:33 ` Eddie James
2023-08-21 4:57 ` Joel Stanley
0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-08-16 17:19 UTC (permalink / raw)
To: Eddie James, Joel Stanley, Jeremy Kerr, Greg Kroah-Hartman
Cc: Alistar Popple, linux-fsi, kernel, linux-kernel
struct i2c_driver::probe_new is about to go away. Switch the driver to
use the probe callback with the same prototype.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
this driver appeared in next just today. I intend to drop .probe_new
from struct i2c_driver after v6.6-rc1, so it would be great if this
patch would go in together with the commit adding this driver.
Thanks
Uwe
drivers/fsi/fsi-master-i2cr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
index 61659c27a973..40f1f4d231e5 100644
--- a/drivers/fsi/fsi-master-i2cr.c
+++ b/drivers/fsi/fsi-master-i2cr.c
@@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
MODULE_DEVICE_TABLE(of, i2cr_ids);
static struct i2c_driver i2cr_driver = {
- .probe_new = i2cr_probe,
+ .probe = i2cr_probe,
.remove = i2cr_remove,
.driver = {
.name = "fsi-master-i2cr",
base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
2023-08-16 17:19 [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe() Uwe Kleine-König
@ 2023-08-16 18:33 ` Eddie James
2023-08-21 4:57 ` Joel Stanley
1 sibling, 0 replies; 4+ messages in thread
From: Eddie James @ 2023-08-16 18:33 UTC (permalink / raw)
To: Uwe Kleine-König, Joel Stanley, Jeremy Kerr,
Greg Kroah-Hartman
Cc: Alistar Popple, linux-fsi, kernel, linux-kernel
On 8/16/23 12:19, Uwe Kleine-König wrote:
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.
Thanks!
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this driver appeared in next just today. I intend to drop .probe_new
> from struct i2c_driver after v6.6-rc1, so it would be great if this
> patch would go in together with the commit adding this driver.
>
> Thanks
> Uwe
>
> drivers/fsi/fsi-master-i2cr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
> index 61659c27a973..40f1f4d231e5 100644
> --- a/drivers/fsi/fsi-master-i2cr.c
> +++ b/drivers/fsi/fsi-master-i2cr.c
> @@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
> MODULE_DEVICE_TABLE(of, i2cr_ids);
>
> static struct i2c_driver i2cr_driver = {
> - .probe_new = i2cr_probe,
> + .probe = i2cr_probe,
> .remove = i2cr_remove,
> .driver = {
> .name = "fsi-master-i2cr",
>
> base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
2023-08-16 17:19 [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe() Uwe Kleine-König
2023-08-16 18:33 ` Eddie James
@ 2023-08-21 4:57 ` Joel Stanley
2023-08-21 5:48 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2023-08-21 4:57 UTC (permalink / raw)
To: Uwe Kleine-König, Greg Kroah-Hartman
Cc: Eddie James, Jeremy Kerr, Alistar Popple, linux-fsi, kernel,
linux-kernel
On Wed, 16 Aug 2023 at 17:20, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this driver appeared in next just today. I intend to drop .probe_new
> from struct i2c_driver after v6.6-rc1, so it would be great if this
> patch would go in together with the commit adding this driver.
Reviewed-by: Joel Stanley <joel@jms.id.au>
Greg, can you please take this for 6.6?
>
> Thanks
> Uwe
>
> drivers/fsi/fsi-master-i2cr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
> index 61659c27a973..40f1f4d231e5 100644
> --- a/drivers/fsi/fsi-master-i2cr.c
> +++ b/drivers/fsi/fsi-master-i2cr.c
> @@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
> MODULE_DEVICE_TABLE(of, i2cr_ids);
>
> static struct i2c_driver i2cr_driver = {
> - .probe_new = i2cr_probe,
> + .probe = i2cr_probe,
> .remove = i2cr_remove,
> .driver = {
> .name = "fsi-master-i2cr",
>
> base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
2023-08-21 4:57 ` Joel Stanley
@ 2023-08-21 5:48 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-08-21 5:48 UTC (permalink / raw)
To: Joel Stanley
Cc: Uwe Kleine-König, Eddie James, Jeremy Kerr, Alistar Popple,
linux-fsi, kernel, linux-kernel
On Mon, Aug 21, 2023 at 04:57:52AM +0000, Joel Stanley wrote:
> On Wed, 16 Aug 2023 at 17:20, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > struct i2c_driver::probe_new is about to go away. Switch the driver to
> > use the probe callback with the same prototype.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> >
> > this driver appeared in next just today. I intend to drop .probe_new
> > from struct i2c_driver after v6.6-rc1, so it would be great if this
> > patch would go in together with the commit adding this driver.
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Greg, can you please take this for 6.6?
Yes, will do, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-21 5:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-16 17:19 [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe() Uwe Kleine-König
2023-08-16 18:33 ` Eddie James
2023-08-21 4:57 ` Joel Stanley
2023-08-21 5:48 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox