From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>,
Alexander Duyck <alexander.duyck@gmail.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Mina Almasry <almasrymina@google.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Liang Chen <liangchen.linux@gmail.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jesper Dangaard Brouer <hawk@kernel.org>
Subject: Re: [PATCH net-next v7 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA
Date: Tue, 22 Aug 2023 08:38:21 -0700 [thread overview]
Message-ID: <20230822083821.58d5d26c@kernel.org> (raw)
In-Reply-To: <5bd4ba5d-c364-f3f6-bbeb-903d71102ea2@huawei.com>
On Tue, 22 Aug 2023 17:21:35 +0800 Yunsheng Lin wrote:
> > .. we should also add a:
> >
> > WARN_ONCE(1, "misaligned DMA address, please report to netdev@");
>
> As the CONFIG_PHYS_ADDR_T_64BIT seems to used widely in x86/arm/mips/powerpc,
> I am not sure if we can really make the above assumption.
>
> https://elixir.free-electrons.com/linux/v6.4-rc6/K/ident/CONFIG_PHYS_ADDR_T_64BIT
Huh, it's actually used a lot less than I anticipated!
None of the x86/arm/mips/powerpc systems matter IMHO - the only _real_
risk is something we don't know about returning non-aligned addresses.
Unless we know about specific problems I'd suggest we took the simpler
path rather than complicating the design for systems which may not
exist.
Alex, do you know of any such cases? Some crazy swiotlb setting?
WDYT about this in general?
next prev parent reply other threads:[~2023-08-22 15:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 10:01 [PATCH net-next v7 0/6] introduce page_pool_alloc() related API Yunsheng Lin
2023-08-16 10:01 ` [PATCH net-next v7 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA Yunsheng Lin
2023-08-17 13:57 ` Ilias Apalodimas
2023-08-17 16:15 ` Jakub Kicinski
2023-08-17 16:59 ` Ilias Apalodimas
2023-08-17 23:57 ` Jakub Kicinski
2023-08-18 6:12 ` Ilias Apalodimas
2023-08-18 8:59 ` Yunsheng Lin
2023-08-18 21:51 ` Jakub Kicinski
2023-08-21 8:38 ` Ilias Apalodimas
2023-08-21 11:15 ` Ilias Apalodimas
2023-08-21 12:18 ` Yunsheng Lin
2023-08-21 18:35 ` Jakub Kicinski
2023-08-22 9:21 ` Yunsheng Lin
2023-08-22 15:38 ` Jakub Kicinski [this message]
2023-08-22 18:30 ` Alexander Duyck
2023-08-22 18:58 ` Alexander Duyck
2023-08-23 3:03 ` Yunsheng Lin
2023-08-23 14:25 ` Jakub Kicinski
2023-08-23 18:00 ` Alexander Duyck
2023-08-25 9:40 ` Yunsheng Lin
2023-08-26 0:08 ` Jakub Kicinski
2023-08-28 14:50 ` Alexander Duyck
2023-08-28 15:38 ` Jakub Kicinski
2023-08-29 11:58 ` Yunsheng Lin
2023-08-16 10:01 ` [PATCH net-next v7 2/6] page_pool: unify frag_count handling in page_pool_is_last_frag() Yunsheng Lin
2023-08-16 11:30 ` Ilias Apalodimas
2023-08-16 12:42 ` Yunsheng Lin
2023-08-16 10:01 ` [PATCH net-next v7 3/6] page_pool: remove PP_FLAG_PAGE_FRAG Yunsheng Lin
2023-08-16 10:01 ` [PATCH net-next v7 4/6] page_pool: introduce page_pool[_cache]_alloc() API Yunsheng Lin
2023-08-16 10:01 ` [PATCH net-next v7 5/6] page_pool: update document about frag API Yunsheng Lin
2023-08-16 10:01 ` [PATCH net-next v7 6/6] net: veth: use newly added page pool API for veth with xdp Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822083821.58d5d26c@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=leon@kernel.org \
--cc=liangchen.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox