* [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify
2023-08-11 15:33 ` [PATCH 0/2] Small fixes for block t10-pi Ankit Kumar
@ 2023-08-11 15:33 ` Ankit Kumar
2023-08-14 1:19 ` Martin K. Petersen
2023-08-11 15:33 ` [PATCH 2/2] block:t10-pi: remove duplicate module license Ankit Kumar
2023-08-22 11:52 ` [PATCH 0/2] Small fixes for block t10-pi Ankit Kumar
2 siblings, 1 reply; 6+ messages in thread
From: Ankit Kumar @ 2023-08-11 15:33 UTC (permalink / raw)
To: Jens Axboe, Martin K. Petersen, Keith Busch
Cc: gost.dev, Ankit Kumar, linux-block, linux-kernel
T10_PI_TYPE2_PROTECTION is neither used to generate nor verify
crc and ip. Remove this redundant check.
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
---
block/t10-pi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/t10-pi.c b/block/t10-pi.c
index 914d8cddd43a..bf0bba01417f 100644
--- a/block/t10-pi.c
+++ b/block/t10-pi.c
@@ -64,8 +64,7 @@ static blk_status_t t10_pi_verify(struct blk_integrity_iter *iter,
struct t10_pi_tuple *pi = iter->prot_buf;
__be16 csum;
- if (type == T10_PI_TYPE1_PROTECTION ||
- type == T10_PI_TYPE2_PROTECTION) {
+ if (type == T10_PI_TYPE1_PROTECTION) {
if (pi->app_tag == T10_PI_APP_ESCAPE)
goto next;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] block:t10-pi: remove duplicate module license
2023-08-11 15:33 ` [PATCH 0/2] Small fixes for block t10-pi Ankit Kumar
2023-08-11 15:33 ` [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify Ankit Kumar
@ 2023-08-11 15:33 ` Ankit Kumar
2023-08-14 1:19 ` Martin K. Petersen
2023-08-22 11:52 ` [PATCH 0/2] Small fixes for block t10-pi Ankit Kumar
2 siblings, 1 reply; 6+ messages in thread
From: Ankit Kumar @ 2023-08-11 15:33 UTC (permalink / raw)
To: Jens Axboe, Martin K. Petersen, Keith Busch
Cc: gost.dev, Ankit Kumar, linux-block, linux-kernel
Remove duplicate MODULE_LICENSE("GPL") from t10-pi.c
Fixes: a7d4383f17e1 ("block: add pi for extended integrity")
Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
---
block/t10-pi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/t10-pi.c b/block/t10-pi.c
index bf0bba01417f..042f21b0e2e5 100644
--- a/block/t10-pi.c
+++ b/block/t10-pi.c
@@ -471,4 +471,3 @@ const struct blk_integrity_profile ext_pi_type3_crc64 = {
EXPORT_SYMBOL_GPL(ext_pi_type3_crc64);
MODULE_LICENSE("GPL");
-MODULE_LICENSE("GPL");
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] Small fixes for block t10-pi
2023-08-11 15:33 ` [PATCH 0/2] Small fixes for block t10-pi Ankit Kumar
2023-08-11 15:33 ` [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify Ankit Kumar
2023-08-11 15:33 ` [PATCH 2/2] block:t10-pi: remove duplicate module license Ankit Kumar
@ 2023-08-22 11:52 ` Ankit Kumar
2 siblings, 0 replies; 6+ messages in thread
From: Ankit Kumar @ 2023-08-22 11:52 UTC (permalink / raw)
To: Jens Axboe, Martin K. Petersen
Cc: kbusch, linux-block, linux-kernel, gost.dev
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Fri, Aug 11, 2023 at 09:03:11PM +0530, Ankit Kumar wrote:
> This series has two patches that:
> - Removes redundant T10_PI_TYPE2_PROTECTION condition check during
> t10_pi_verify.
> - Removes duplicate module license introduced in an earlier commit.
>
> Ankit Kumar (2):
> block:t10-pi: remove redundant Type2 check during t10 PI verify
> block:t10-pi: remove duplicate module license
>
> block/t10-pi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> --
> 2.25.1
>
>
Hi Jens,
These two patches have been reviewed by Martin.
Can you please take a look.
Ankit
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread