Re: [PATCH v4] Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C function to GPI

Yann Sionneau
2023-08-22T14:17:07Z

Hi,

On 8/22/23 15:26, Andy Shevchenko wrote:
> On Tue, Aug 22, 2023 at 03:11:23PM +0200, Yann Sionneau wrote:
>> scl-gpio = <>;
>> sda-gpio = <>;
>>
>> Are not enough for some SoCs to have a working recovery.
>> Some need:
>>
>> scl-gpio = <>;
>> sda-gpio = <>;
>> pinctrl-names = "default", "recovery";
>> pinctrl-0 = <&i2c_pins_hw>;
>> pinctrl-1 = <&i2c_pins_gpio>;
>>
>> The driver was not filling rinfo->pinctrl with the device node
>> pinctrl data which is needed by generic recovery code.
>>
>> Signed-off-by: Yann Sionneau <ysionneau@kalray.eu>
>> ---
>> V3 -> V4:
>> * Replace `else if` by simply `if`.
> You forgot my tag. Why?
Woops sorry, I am not used to sending patches upstream. I didn't know I
had to add the ack tag. Will do it!
> Also I think this will generate more code and more noise in debug case.
> So, I admit I gave a bad suggestion in previous round.
Ah yes you are right in case of dbg+CONFIG_PINCTRL not set it will print
both messages but just one is enough.
>
> Please, go for v3 with my tag (as v5).
>
Ok, I'll also add `i2c: designware: ` to $subject as Mika Westerberg
suggested.

Thanks,

--

Yann