Re: [PATCH v4] Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C function to GPI

Mika Westerberg
2023-08-22T13:35:57Z

On Tue, Aug 22, 2023 at 04:26:08PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 22, 2023 at 03:11:23PM +0200, Yann Sionneau wrote:
> > scl-gpio = <>;
> > sda-gpio = <>;
> >
> > Are not enough for some SoCs to have a working recovery.
> > Some need:
> >
> > scl-gpio = <>;
> > sda-gpio = <>;
> > pinctrl-names = "default", "recovery";
> > pinctrl-0 = <&i2c_pins_hw>;
> > pinctrl-1 = <&i2c_pins_gpio>;
> >
> > The driver was not filling rinfo->pinctrl with the device node
> > pinctrl data which is needed by generic recovery code.
> >
> > Signed-off-by: Yann Sionneau <ysionneau@kalray.eu>
> > ---
> > V3 -> V4:
> > * Replace `else if` by simply `if`.
>
> You forgot my tag. Why?
> Also I think this will generate more code and more noise in debug case.
> So, I admit I gave a bad suggestion in previous round.
>
> Please, go for v3 with my tag (as v5).

While there fix $subject to follow the convention used in the driver.