Re: [PATCH v4] Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C function to GPI

Andy Shevchenko
2023-08-22T14:27:33Z

On Tue, Aug 22, 2023 at 04:15:25PM +0200, Yann Sionneau wrote:
> On 8/22/23 15:26, Andy Shevchenko wrote:
> > On Tue, Aug 22, 2023 at 03:11:23PM +0200, Yann Sionneau wrote:

...

> > You forgot my tag. Why?
> Woops sorry, I am not used to sending patches upstream. I didn't know I had
> to add the ack tag. Will do it!

Any tags, Acked-by, Reviewed-by, ...

> > Also I think this will generate more code and more noise in debug case.
> > So, I admit I gave a bad suggestion in previous round.
> Ah yes you are right in case of dbg+CONFIG_PINCTRL not set it will print
> both messages but just one is enough.
> >
> > Please, go for v3 with my tag (as v5).
> >
> Ok, I'll also add `i2c: designware: ` to $subject as Mika Westerberg
> suggested.

It seems that Subject was completely missing.
In the commit message it's a first line followed by a blank line.

--
With Best Regards,
Andy Shevchenko