Re: [PATCH v2 1/2] mtd: spinand: micron: correct bitmask for ecc status

Frieder Schrempf
2023-08-22T12:30:14Z

On 22.08.23 14:25, Martin Kurbanov wrote:
> Valid bitmask is 0x70 in the status register.
>
> Signed-off-by: Martin Kurbanov <mmkurbanov@sberdevices.ru>

This should have a Fixes tag like:

Fixes: a508e8875e13 ("mtd: spinand: Add initial support for Micron
MT29F2G01ABAGD")

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

> ---
> drivers/mtd/nand/spi/micron.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/spi/micron.c b/drivers/mtd/nand/spi/micron.c
> index 50b7295bc922..12601bc4227a 100644
> --- a/drivers/mtd/nand/spi/micron.c
> +++ b/drivers/mtd/nand/spi/micron.c
> @@ -12,7 +12,7 @@
>
> #define SPINAND_MFR_MICRON 0x2c
>
> -#define MICRON_STATUS_ECC_MASK GENMASK(7, 4)
> +#define MICRON_STATUS_ECC_MASK GENMASK(6, 4)
> #define MICRON_STATUS_ECC_NO_BITFLIPS (0 << 4)
> #define MICRON_STATUS_ECC_1TO3_BITFLIPS (1 << 4)
> #define MICRON_STATUS_ECC_4TO6_BITFLIPS (3 << 4)