From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85707EE4993 for ; Wed, 23 Aug 2023 14:25:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230049AbjHWOZ6 (ORCPT ); Wed, 23 Aug 2023 10:25:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235683AbjHWOZ5 (ORCPT ); Wed, 23 Aug 2023 10:25:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1033AE68 for ; Wed, 23 Aug 2023 07:25:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F24D615BF for ; Wed, 23 Aug 2023 14:25:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0599EC433C9; Wed, 23 Aug 2023 14:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692800753; bh=YxgrXikt9Lvvqkt6X1fJSal7MTHblE3Cq8OOJIBxl6M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hHphIuUnFB5bZjd3v1ZkPUtFfDrS0R4UvfnnOHZEkvNrRZHMqCNzwQMrXnDoQ9myM DmOPMilKIV38h3aJ54GOiXu0Nl4/yHb4ZgFkxMUuLPUGUmdBhB3fe+U94tMFrPJPd1 /NIG9V9tf3p6GDF9iY0gzQdGuQdyhP4ScpANHmbmtDhPvHP/fvHhkJkY+Vl4CMUBc5 IOVOp/2xlkOBVasDvIAsxcxiWr6uxEU83MqJjTHZZ9laMXSh7rGeHhe4JsDSMeHA1T 0MaL7GFlv1arHSlGAYj3JEiKVKuvn2UzRPJj8eejhqVn0WNcEevQXp3+gMcYQsDe5a D/+q6z/qQTYhA== Date: Wed, 23 Aug 2023 07:25:52 -0700 From: Jakub Kicinski To: Yunsheng Lin Cc: Alexander Duyck , Ilias Apalodimas , Mina Almasry , , , , , Lorenzo Bianconi , Liang Chen , Alexander Lobakin , Saeed Mahameed , Leon Romanovsky , Eric Dumazet , Jesper Dangaard Brouer Subject: Re: [PATCH net-next v7 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA Message-ID: <20230823072552.044d13b3@kernel.org> In-Reply-To: <79a49ccd-b0c0-0b99-4b4d-c4a416d7e327@huawei.com> References: <20230816100113.41034-1-linyunsheng@huawei.com> <20230816100113.41034-2-linyunsheng@huawei.com> <20230817091554.31bb3600@kernel.org> <20230817165744.73d61fb6@kernel.org> <20230818145145.4b357c89@kernel.org> <1b8e2681-ccd6-81e0-b696-8b6c26e31f26@huawei.com> <20230821113543.536b7375@kernel.org> <5bd4ba5d-c364-f3f6-bbeb-903d71102ea2@huawei.com> <20230822083821.58d5d26c@kernel.org> <79a49ccd-b0c0-0b99-4b4d-c4a416d7e327@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Aug 2023 11:03:31 +0800 Yunsheng Lin wrote: > On 2023/8/22 23:38, Jakub Kicinski wrote: > > On Tue, 22 Aug 2023 17:21:35 +0800 Yunsheng Lin wrote: > >> As the CONFIG_PHYS_ADDR_T_64BIT seems to used widely in x86/arm/mips/powerpc, > >> I am not sure if we can really make the above assumption. > >> > >> https://elixir.free-electrons.com/linux/v6.4-rc6/K/ident/CONFIG_PHYS_ADDR_T_64BIT > > > > Huh, it's actually used a lot less than I anticipated! > > > > None of the x86/arm/mips/powerpc systems matter IMHO - the only _real_ > > Is there any particular reason that you think that the above systems does > not really matter? Not the systems themselves but the combination of a 32b arch with an address space >16TB. All those arches have 64b equivalent, seems logical to use the 64b version for a system with a large address space. If we're talking about a system which ends up running Linux. > As we have made a similar wrong assumption about those arches before, I am > really trying to be more cautious about it. > > I searched through the web, some seems to be claiming that "32-bits is DEAD", > I am not sure if there is some common agreement among the kernel community, > is there any previous discussion about that? My suspicion/claim is that 32 + PAGE_SHIFT should be enough bits for any 32b platform.