* [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata()
@ 2023-08-23 11:21 Andrei Coardos
2023-08-23 13:44 ` Martin Kaiser
2023-09-15 10:37 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Andrei Coardos @ 2023-08-23 11:21 UTC (permalink / raw)
To: linux-kernel, linux-crypto; +Cc: alex, herbert, olivia, Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/char/hw_random/hisi-rng.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
index 96438f85cafa..b6f27566e0ba 100644
--- a/drivers/char/hw_random/hisi-rng.c
+++ b/drivers/char/hw_random/hisi-rng.c
@@ -79,8 +79,6 @@ static int hisi_rng_probe(struct platform_device *pdev)
if (!rng)
return -ENOMEM;
- platform_set_drvdata(pdev, rng);
-
rng->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(rng->base))
return PTR_ERR(rng->base);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata()
2023-08-23 11:21 [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata() Andrei Coardos
@ 2023-08-23 13:44 ` Martin Kaiser
2023-08-24 8:28 ` Alexandru Ardelean
2023-09-15 10:37 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Martin Kaiser @ 2023-08-23 13:44 UTC (permalink / raw)
To: Andrei Coardos; +Cc: linux-kernel, linux-crypto, alex, herbert, olivia
Andrei Coardos (aboutphysycs@gmail.com) wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/char/hw_random/hisi-rng.c | 2 --
> 1 file changed, 2 deletions(-)
> diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> index 96438f85cafa..b6f27566e0ba 100644
> --- a/drivers/char/hw_random/hisi-rng.c
> +++ b/drivers/char/hw_random/hisi-rng.c
> @@ -79,8 +79,6 @@ static int hisi_rng_probe(struct platform_device *pdev)
> if (!rng)
> return -ENOMEM;
> - platform_set_drvdata(pdev, rng);
> -
> rng->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(rng->base))
> return PTR_ERR(rng->base);
> --
> 2.34.1
This one can go.
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata()
2023-08-23 13:44 ` Martin Kaiser
@ 2023-08-24 8:28 ` Alexandru Ardelean
0 siblings, 0 replies; 4+ messages in thread
From: Alexandru Ardelean @ 2023-08-24 8:28 UTC (permalink / raw)
To: Martin Kaiser; +Cc: Andrei Coardos, linux-kernel, linux-crypto, herbert, olivia
On Wed, Aug 23, 2023 at 4:44 PM Martin Kaiser <lists@kaiser.cx> wrote:
>
> Andrei Coardos (aboutphysycs@gmail.com) wrote:
>
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
>
> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> > ---
> > drivers/char/hw_random/hisi-rng.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> > diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> > index 96438f85cafa..b6f27566e0ba 100644
> > --- a/drivers/char/hw_random/hisi-rng.c
> > +++ b/drivers/char/hw_random/hisi-rng.c
> > @@ -79,8 +79,6 @@ static int hisi_rng_probe(struct platform_device *pdev)
> > if (!rng)
> > return -ENOMEM;
>
> > - platform_set_drvdata(pdev, rng);
> > -
> > rng->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(rng->base))
> > return PTR_ERR(rng->base);
> > --
> > 2.34.1
>
> This one can go.
>
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Reviewed-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata()
2023-08-23 11:21 [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-23 13:44 ` Martin Kaiser
@ 2023-09-15 10:37 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2023-09-15 10:37 UTC (permalink / raw)
To: Andrei Coardos; +Cc: linux-kernel, linux-crypto, alex, olivia
On Wed, Aug 23, 2023 at 02:21:39PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/char/hw_random/hisi-rng.c | 2 --
> 1 file changed, 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-15 10:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-23 11:21 [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-23 13:44 ` Martin Kaiser
2023-08-24 8:28 ` Alexandru Ardelean
2023-09-15 10:37 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox