From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>,
Damien Le Moal <dlemoal@kernel.org>, <bhelgaas@google.com>,
<linux-pci@vger.kernel.org>, <alex.williamson@redhat.com>,
<christian.koenig@amd.com>, <kch@nvidia.com>,
<gregkh@linuxfoundation.org>, <logang@deltatee.com>,
<linux-kernel@vger.kernel.org>, <chaitanyak@nvidia.com>,
<rdunlap@infradead.org>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v4] PCI/DOE: Expose the DOE protocols via sysfs
Date: Wed, 23 Aug 2023 13:10:13 +0100 [thread overview]
Message-ID: <20230823131013.000005b9@Huawei.com> (raw)
In-Reply-To: <CAKmqyKMRxN68N_29HjEDb2UVU+_RyAc7Z7+iouHP_xq3f_UX0g@mail.gmail.com>
On Tue, 15 Aug 2023 14:36:31 -0400
Alistair Francis <alistair23@gmail.com> wrote:
> On Sat, Aug 12, 2023 at 4:21 AM Lukas Wunner <lukas@wunner.de> wrote:
> >
> > On Fri, Aug 11, 2023 at 10:03:58AM +0900, Damien Le Moal wrote:
> > > On 8/11/23 01:33, Alistair Francis wrote:
> > > > Each DOE feature is exposed as a single file. The files are empty and
> > > > the information is contained in the file name.
> > >
> > > s/feature/protocol ?
> >
> > DOE r1.1 replaced all occurrences of "protocol" with the term "feature"
> > or "Data Object Type".
> >
> > PCIe r6.1 (which was published July 24) incorporated that change.
> >
> > So going forward the term "protocol" is deprecated in the DOE context.
> >
> > We should use the terms used by the (latest) PCIe Base Spec so that
> > users can easily make the connection between the language in the spec
> > and our code.
> >
> > Unfortunately this patch uses a mix of "protocol" and "feature".
> > It should use the latter term exclusively.
>
> The existing file uses protocols, so I have tried to match the
> existing style. I have changed the names to feature though
Feel free to fix the rest of the file as a precursor ;)
Jonathan
>
> Alistair
>
> >
> > Thanks,
> >
> > Lukas
next prev parent reply other threads:[~2023-08-23 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 16:33 [PATCH v4] PCI/DOE: Expose the DOE protocols via sysfs Alistair Francis
2023-08-11 1:03 ` Damien Le Moal
2023-08-11 18:40 ` Alistair Francis
2023-08-11 19:47 ` Greg KH
2023-08-12 8:05 ` Lukas Wunner
2023-08-12 8:31 ` Lukas Wunner
2023-08-12 8:21 ` Lukas Wunner
2023-08-15 18:36 ` Alistair Francis
2023-08-23 12:10 ` Jonathan Cameron [this message]
2023-08-11 5:21 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823131013.000005b9@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bhelgaas@google.com \
--cc=chaitanyak@nvidia.com \
--cc=christian.koenig@amd.com \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=lukas@wunner.de \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox