From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DD4EE49B6 for ; Wed, 23 Aug 2023 12:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234860AbjHWMKs convert rfc822-to-8bit (ORCPT ); Wed, 23 Aug 2023 08:10:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234900AbjHWMKo (ORCPT ); Wed, 23 Aug 2023 08:10:44 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9EF31716; Wed, 23 Aug 2023 05:10:20 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RW4lH6Syfz67QqC; Wed, 23 Aug 2023 20:09:31 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 23 Aug 2023 13:10:14 +0100 Date: Wed, 23 Aug 2023 13:10:13 +0100 From: Jonathan Cameron To: Alistair Francis CC: Lukas Wunner , Damien Le Moal , , , , , , , , , , , Alistair Francis Subject: Re: [PATCH v4] PCI/DOE: Expose the DOE protocols via sysfs Message-ID: <20230823131013.000005b9@Huawei.com> In-Reply-To: References: <20230810163342.1059509-1-alistair.francis@wdc.com> <20230812082108.GD9469@wunner.de> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Aug 2023 14:36:31 -0400 Alistair Francis wrote: > On Sat, Aug 12, 2023 at 4:21 AM Lukas Wunner wrote: > > > > On Fri, Aug 11, 2023 at 10:03:58AM +0900, Damien Le Moal wrote: > > > On 8/11/23 01:33, Alistair Francis wrote: > > > > Each DOE feature is exposed as a single file. The files are empty and > > > > the information is contained in the file name. > > > > > > s/feature/protocol ? > > > > DOE r1.1 replaced all occurrences of "protocol" with the term "feature" > > or "Data Object Type". > > > > PCIe r6.1 (which was published July 24) incorporated that change. > > > > So going forward the term "protocol" is deprecated in the DOE context. > > > > We should use the terms used by the (latest) PCIe Base Spec so that > > users can easily make the connection between the language in the spec > > and our code. > > > > Unfortunately this patch uses a mix of "protocol" and "feature". > > It should use the latter term exclusively. > > The existing file uses protocols, so I have tried to match the > existing style. I have changed the names to feature though Feel free to fix the rest of the file as a precursor ;) Jonathan > > Alistair > > > > > Thanks, > > > > Lukas