* [PATCH] watchdog: stm32: Drop unnecessary of_match_ptr()
@ 2023-08-23 15:10 Rob Herring
2023-08-23 15:38 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2023-08-23 15:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Maxime Coquelin,
Alexandre Torgue
Cc: kernel test robot, linux-watchdog, linux-stm32, linux-arm-kernel,
linux-kernel
With COMPILE_TEST recently enabled, 0-day reports a warning:
drivers/watchdog/stm32_iwdg.c:215:34: warning: 'stm32_iwdg_of_match' defined but not used [-Wunused-const-variable=]
As STM32 platforms are always used with DT, drop the of_match_ptr().
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308211837.4VBSUAtZ-lkp@intel.com/
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/watchdog/stm32_iwdg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
index 570a71509d2a..9a554a3db4e2 100644
--- a/drivers/watchdog/stm32_iwdg.c
+++ b/drivers/watchdog/stm32_iwdg.c
@@ -288,7 +288,7 @@ static struct platform_driver stm32_iwdg_driver = {
.probe = stm32_iwdg_probe,
.driver = {
.name = "iwdg",
- .of_match_table = of_match_ptr(stm32_iwdg_of_match),
+ .of_match_table = stm32_iwdg_of_match,
},
};
module_platform_driver(stm32_iwdg_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] watchdog: stm32: Drop unnecessary of_match_ptr()
2023-08-23 15:10 [PATCH] watchdog: stm32: Drop unnecessary of_match_ptr() Rob Herring
@ 2023-08-23 15:38 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2023-08-23 15:38 UTC (permalink / raw)
To: Rob Herring
Cc: Wim Van Sebroeck, Maxime Coquelin, Alexandre Torgue,
kernel test robot, linux-watchdog, linux-stm32, linux-arm-kernel,
linux-kernel
On Wed, Aug 23, 2023 at 10:10:59AM -0500, Rob Herring wrote:
> With COMPILE_TEST recently enabled, 0-day reports a warning:
>
> drivers/watchdog/stm32_iwdg.c:215:34: warning: 'stm32_iwdg_of_match' defined but not used [-Wunused-const-variable=]
>
> As STM32 platforms are always used with DT, drop the of_match_ptr().
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308211837.4VBSUAtZ-lkp@intel.com/
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/stm32_iwdg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
> index 570a71509d2a..9a554a3db4e2 100644
> --- a/drivers/watchdog/stm32_iwdg.c
> +++ b/drivers/watchdog/stm32_iwdg.c
> @@ -288,7 +288,7 @@ static struct platform_driver stm32_iwdg_driver = {
> .probe = stm32_iwdg_probe,
> .driver = {
> .name = "iwdg",
> - .of_match_table = of_match_ptr(stm32_iwdg_of_match),
> + .of_match_table = stm32_iwdg_of_match,
> },
> };
> module_platform_driver(stm32_iwdg_driver);
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-23 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-23 15:10 [PATCH] watchdog: stm32: Drop unnecessary of_match_ptr() Rob Herring
2023-08-23 15:38 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox