From: Liam Beguin <liambeguin@gmail.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
sboyd@kernel.org, mturquette@baylibre.com
Subject: Re: [PATCH 1/3] clk: lmk04832: Set missing parent_names for output clocks
Date: Wed, 23 Aug 2023 15:13:58 -0400 [thread overview]
Message-ID: <20230823191358.GA2572839@shaak> (raw)
In-Reply-To: <20230802064100.15793-1-mike.looijmans@topic.nl>
On Wed, Aug 02, 2023 at 08:40:58AM +0200, Mike Looijmans wrote:
> lmk04832_register_clkout forgot to fill in the parent_names, resulting
> in the error message "Must specify parents if num_parents > 0".
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Reviewed-by: Liam Beguin <liambeguin@gmail.com>
> ---
> drivers/clk/clk-lmk04832.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
> index e22ac93e0c2f..188085e7a30b 100644
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1297,6 +1297,7 @@ static int lmk04832_register_clkout(struct lmk04832 *lmk, const int num)
> sprintf(dclk_name, "lmk-dclk%02d_%02d", num, num + 1);
> init.name = dclk_name;
> parent_names[0] = clk_hw_get_name(&lmk->vco);
> + init.parent_names = parent_names;
> init.ops = &lmk04832_dclk_ops;
> init.flags = CLK_SET_RATE_PARENT;
> init.num_parents = 1;
> --
> 2.17.1
>
>
> Met vriendelijke groet / kind regards,
>
> Mike Looijmans
> System Expert
>
>
> TOPIC Embedded Products B.V.
> Materiaalweg 4, 5681 RJ Best
> The Netherlands
>
> T: +31 (0) 499 33 69 69
> E: mike.looijmans@topicproducts.com
> W: www.topic.nl
>
> Please consider the environment before printing this e-mail
next prev parent reply other threads:[~2023-08-23 19:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.05b2cfbe-0414-4869-b825-034b9be5bf9a@emailsignatures365.codetwo.com>
2023-08-02 6:40 ` [PATCH 1/3] clk: lmk04832: Set missing parent_names for output clocks Mike Looijmans
2023-08-02 6:40 ` [PATCH 2/3] clk: lmk04832: Don't disable vco clock on probe fail Mike Looijmans
2023-08-23 19:14 ` Liam Beguin
2023-08-23 22:48 ` Stephen Boyd
2023-08-02 6:41 ` [PATCH 3/3] clk: lmk04832: Support using PLL1_LD as SPI readback pin Mike Looijmans
2023-08-23 19:15 ` Liam Beguin
2023-08-23 22:48 ` Stephen Boyd
2023-08-23 19:13 ` Liam Beguin [this message]
2023-08-23 22:48 ` [PATCH 1/3] clk: lmk04832: Set missing parent_names for output clocks Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823191358.GA2572839@shaak \
--to=liambeguin@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox