From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839E0C3DA6F for ; Wed, 23 Aug 2023 21:14:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235594AbjHWVNq (ORCPT ); Wed, 23 Aug 2023 17:13:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237158AbjHWVNQ (ORCPT ); Wed, 23 Aug 2023 17:13:16 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D40910E5 for ; Wed, 23 Aug 2023 14:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692825193; x=1724361193; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=defJ4soWaA1pNiXr8MEpc33gCgleHCb3i8oy08Xij0k=; b=YY2cMkGDZ2MizRJt9npcIzOKwXOALJpxFLLU6nFXqBs8EQGOGro0K6WL mCExtmFI0WySPdaSaUg8SASit+u+eaPDPGQ6Ajv1Bc4X6FfV3+Hv7tUG2 Of9IuhyLtg2VQZrRIPrKZXKsNup6N0IbTx0AVZU88dehFSdGg5h3dpDbL RUzTLUI8YZn63AhMImdzuSFgSWKkFq3QFEVsXYz0SdUJ/KUyZsWV8Ezqo zJkSziM1tcR9dIHtTvqj+SWehG/xKauYtTfo/mrPmdTpxu+KGEdFlxxSA FtnES4sIBL3qqtLK/6GrZJoexT3BMwm02ncex4w7UhmpZ+8zT1Fk3wOj6 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="353819303" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="353819303" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2023 14:13:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="851197932" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="851197932" Received: from lkp-server02.sh.intel.com (HELO daf8bb0a381d) ([10.239.97.151]) by fmsmga002.fm.intel.com with ESMTP; 23 Aug 2023 14:13:07 -0700 Received: from kbuild by daf8bb0a381d with local (Exim 4.96) (envelope-from ) id 1qYvA2-0001Vq-0c; Wed, 23 Aug 2023 21:13:06 +0000 Date: Thu, 24 Aug 2023 05:12:11 +0800 From: kernel test robot To: John Stultz , LKML Cc: oe-kbuild-all@lists.linux.dev, John Stultz , Joel Fernandes , Qais Yousef , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Youssef Esmat , Mel Gorman , Daniel Bristot de Oliveira , Will Deacon , Waiman Long , Boqun Feng , "Paul E . McKenney" , kernel-team@android.com Subject: Re: [PATCH v5 13/19] sched: Split out __sched() deactivate task logic into a helper Message-ID: <202308240439.2aDXO6Ks-lkp@intel.com> References: <20230819060915.3001568-14-jstultz@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230819060915.3001568-14-jstultz@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, kernel test robot noticed the following build warnings: [auto build test WARNING on tip/locking/core] [also build test WARNING on linus/master tip/auto-latest v6.5-rc7] [cannot apply to tip/sched/core tip/master next-20230823] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/John-Stultz/sched-Unify-runtime-accounting-across-classes/20230821-121604 base: tip/locking/core patch link: https://lore.kernel.org/r/20230819060915.3001568-14-jstultz%40google.com patch subject: [PATCH v5 13/19] sched: Split out __sched() deactivate task logic into a helper config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20230824/202308240439.2aDXO6Ks-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230824/202308240439.2aDXO6Ks-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308240439.2aDXO6Ks-lkp@intel.com/ All warnings (new ones prefixed by >>): >> kernel/sched/core.c:6565:6: warning: no previous prototype for 'try_to_deactivate_task' [-Wmissing-prototypes] 6565 | bool try_to_deactivate_task(struct rq *rq, struct task_struct *p, unsigned long state) | ^~~~~~~~~~~~~~~~~~~~~~ vim +/try_to_deactivate_task +6565 kernel/sched/core.c 6564 > 6565 bool try_to_deactivate_task(struct rq *rq, struct task_struct *p, unsigned long state) 6566 { 6567 if (signal_pending_state(state, p)) { 6568 WRITE_ONCE(p->__state, TASK_RUNNING); 6569 } else { 6570 p->sched_contributes_to_load = 6571 (state & TASK_UNINTERRUPTIBLE) && 6572 !(state & TASK_NOLOAD) && 6573 !(state & TASK_FROZEN); 6574 6575 if (p->sched_contributes_to_load) 6576 rq->nr_uninterruptible++; 6577 6578 /* 6579 * __schedule() ttwu() 6580 * prev_state = prev->state; if (p->on_rq && ...) 6581 * if (prev_state) goto out; 6582 * p->on_rq = 0; smp_acquire__after_ctrl_dep(); 6583 * p->state = TASK_WAKING 6584 * 6585 * Where __schedule() and ttwu() have matching control dependencies. 6586 * 6587 * After this, schedule() must not care about p->state any more. 6588 */ 6589 deactivate_task(rq, p, DEQUEUE_SLEEP | DEQUEUE_NOCLOCK); 6590 6591 if (p->in_iowait) { 6592 atomic_inc(&rq->nr_iowait); 6593 delayacct_blkio_start(); 6594 } 6595 return true; 6596 } 6597 return false; 6598 } 6599 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki