public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: lee@kernel.org
Cc: linux-kernel@vger.kernel.org,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/20] drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible values can be stored
Date: Thu, 24 Aug 2023 08:36:59 +0100	[thread overview]
Message-ID: <20230824073710.2677348-15-lee@kernel.org> (raw)
In-Reply-To: <20230824073710.2677348-1-lee@kernel.org>

When converting from int to string, we must allow for up to 10-chars (2147483647).

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/imx/ipuv3/imx-ldb.c: In function ‘imx_ldb_probe’:
 drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:39: warning: ‘_sel’ directive writing 4 bytes into a region of size between 3 and 13 [-Wformat-overflow=]
 drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:17: note: ‘sprintf’ output between 8 and 18 bytes into a destination of size 16

Signed-off-by: Lee Jones <lee@kernel.org>
---
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
index c45fc8f4744d0..0404781dcd176 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-ldb.c
@@ -654,7 +654,7 @@ static int imx_ldb_probe(struct platform_device *pdev)
 	 * Map them all to di0_sel...di3_sel.
 	 */
 	for (i = 0; i < 4; i++) {
-		char clkname[16];
+		char clkname[18];
 
 		sprintf(clkname, "di%d_sel", i);
 		imx_ldb->clk_sel[i] = devm_clk_get(imx_ldb->dev, clkname);
-- 
2.42.0.rc1.204.g551eb34607-goog


  parent reply	other threads:[~2023-08-24  7:38 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  7:36 [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Lee Jones
2023-08-24  7:36 ` [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Lee Jones
2023-08-28 16:39   ` Laurent Pinchart
2023-08-28 19:33     ` Randy Dunlap
2023-08-24  7:36 ` [PATCH 02/20] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc' Lee Jones
2023-08-24  7:36 ` [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses Lee Jones
2023-08-24  8:41   ` Karol Herbst
2023-08-24  7:36 ` [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses Lee Jones
2023-08-24  8:41   ` Karol Herbst
2023-08-24  7:36 ` [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse Lee Jones
2023-08-24  8:41   ` Karol Herbst
2023-08-24  7:36 ` [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses Lee Jones
2023-08-24  8:42   ` Karol Herbst
2023-08-24  7:36 ` [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move() Lee Jones
2023-08-24 14:53   ` Alex Deucher
2023-08-24  7:36 ` [PATCH 08/20] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers Lee Jones
2023-08-24  7:36 ` [PATCH 09/20] drm/tests/drm_kunit_helpers: Place correct function name in the comment header Lee Jones
2023-08-24  7:36 ` [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result' Lee Jones
2023-08-24  9:42   ` [Linaro-mm-sig] " Christian König
2023-08-24  7:36 ` [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index' Lee Jones
2023-08-24  8:25   ` Sharma, Shashank
2023-08-24 14:59     ` Alex Deucher
2023-08-24  7:36 ` [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id' Lee Jones
2023-08-24 14:54   ` Alex Deucher
2023-08-24  7:36 ` [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc' Lee Jones
2023-08-24  8:53   ` Maxime Ripard
2023-08-24 12:11     ` Lee Jones
2023-08-24  7:36 ` Lee Jones [this message]
2023-08-24  7:37 ` [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored Lee Jones
2023-08-24  9:25   ` Thierry Reding
2023-08-24  9:33     ` Jani Nikula
2023-08-24 12:01       ` Lee Jones
2023-08-24 13:45         ` Thierry Reding
2023-08-24  7:37 ` [PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces' Lee Jones
2023-08-24  9:00   ` (subset) " Maxime Ripard
2023-08-24  7:37 ` [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values Lee Jones
2023-08-24 14:55   ` Alex Deucher
2023-08-24  7:37 ` [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev' Lee Jones
2023-08-24 12:53   ` Danilo Krummrich
2023-08-24  7:37 ` [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values Lee Jones
2023-08-24 14:56   ` Alex Deucher
2023-08-24  7:37 ` [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored Lee Jones
2023-08-24 14:57   ` Alex Deucher
2023-08-24  8:59 ` [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Maxime Ripard
2023-08-24  9:03   ` Maxime Ripard
2023-08-24 12:10     ` Lee Jones
2023-08-24  9:03 ` Jani Nikula
2023-08-24  9:16   ` Maxime Ripard
2023-08-24 12:07   ` Lee Jones
2023-08-24 12:08     ` Lee Jones
2023-08-24 12:14     ` Hamza Mahfooz
2023-08-24 12:24       ` Lee Jones
2023-08-28 16:11     ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230824073710.2677348-15-lee@kernel.org \
    --to=lee@kernel.org \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox