RE: [PATCH v3 09/10] x86/hyperv: Remove hv_isolation_type_en_snp

Michael Kelley (LINUX)
2023-08-24T14:10:22Z

From: Dexuan Cui <decui@microsoft.com> Sent: Thursday, August 24, 2023 1:07 AM
>
> In ms_hyperv_init_platform(), do not distinguish between a SNP VM with
> the paravisor and a SNP VM without the paravisor.
>
> Replace hv_isolation_type_en_snp() with
> !ms_hyperv.paravisor_present && hv_isolation_type_snp().
>
> The hv_isolation_type_en_snp() in drivers/hv/hv.c and
> drivers/hv/hv_common.c can be changed to hv_isolation_type_snp() since
> we know !ms_hyperv.paravisor_present is true there.
>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> ---
>
> Changes in v2:
> Rebased to Tianyu's v7 SNP patchset: the changes are small.
> In hyperv_init_ghcb() and hyperv_init(), added the test of
> hyperv_paravisor_present, which was missed in v1.
> Updated the test before the call of get_vtl().
> Updated the test in hv_do_hypercall() and friends.
> Updated the test for hv_smp_prepare_cpus().
>
> Changes in v3:
> hyperv_paravisor_present -> ms_hyperv.paravisor_present
>
>
> arch/x86/hyperv/hv_init.c | 8 ++++----
> arch/x86/hyperv/ivm.c | 12 +-----------
> arch/x86/include/asm/mshyperv.h | 11 ++++-------
> arch/x86/kernel/cpu/mshyperv.c | 10 ++++------
> drivers/hv/hv.c | 4 ++--
> drivers/hv/hv_common.c | 8 +-------
> include/asm-generic/mshyperv.h | 3 +--
> 7 files changed, 17 insertions(+), 39 deletions(-)
>

Reviewed-by: Michael Kelley <mikelley@microsoft.com>