Re: [PATCH 4/5] hwtracing: hisi_ptt: Don't try to attach a task

Jonathan Cameron
2023-08-25T11:26:21Z

On Wed, 9 Aug 2023 16:18:24 +0800
Yicong Yang <yangyicong@huawei.com> wrote:

> From: Yicong Yang <yangyicong@hisilicon.com>
>
> PTT is an uncore PMU and shouldn't be attached to any task. Block
> the usage in pmu::event_init().
>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> drivers/hwtracing/ptt/hisi_ptt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c
> index 3aba7bb6e548..916686c6a9c8 100644
> --- a/drivers/hwtracing/ptt/hisi_ptt.c
> +++ b/drivers/hwtracing/ptt/hisi_ptt.c
> @@ -1003,6 +1003,9 @@ static int hisi_ptt_pmu_event_init(struct perf_event *event)
> return -EOPNOTSUPP;
> }
>
> + if (event->attach_state & PERF_ATTACH_TASK)
> + return -EOPNOTSUPP;
> +
> if (event->attr.type != hisi_ptt->hisi_ptt_pmu.type)
> return -ENOENT;
>