From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9133BC83F18 for ; Sat, 26 Aug 2023 05:54:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230344AbjHZFxj (ORCPT ); Sat, 26 Aug 2023 01:53:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231148AbjHZFxb (ORCPT ); Sat, 26 Aug 2023 01:53:31 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 783A126AD for ; Fri, 25 Aug 2023 22:53:28 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1bdbbede5d4so13334545ad.2 for ; Fri, 25 Aug 2023 22:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693029208; x=1693634008; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8a8yRHibxZaMQvp8EuhSuU+8SaRLddJ0DMHrupkDBok=; b=GjP+E8MXeN21Nul3dWASH87dmTBT6gsSnR60OTl16V9oleYd7rPu9Z3KvsUuectm4G 9A7AbakZbHykqI2zkLqfFnNVIzrQjl14tbuV4vjAT6d7qFKQ2ucP0tao/lhQq7eI4WUW 67OxTAvIdz24IBVov+9wc4hEo3/y2uNOy7T2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693029208; x=1693634008; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8a8yRHibxZaMQvp8EuhSuU+8SaRLddJ0DMHrupkDBok=; b=eK60YsVMMFaRz7zMQtyeqOe2kca2QhCfvFOgDH3sKwKEYqGcE9ImMO30fvHyRS3x/d BuDr9uy/tRS/3UEUMlcUROvCHpvyFHnV/O2siAmkGeg9WlpQypf6pSzSzIqA42gEflpb ZAK5XHlLbschqKSM1jFKLZ2Pju0307e2kij5LJRN500P3wJItuLHmTEFYkvE+OWk/q4H +fPYA8egDpTlCuEOnH4c4U3ugnbgnir1h2WPCzhG+MjgcORAPM06YFVN1K0tpaMCX2w4 J/w4jdEjEDXGi7AL3E99lTjjtdySCaUkGI2xIaphICi5h/1ImdTEHoP3gOS6hlyLXRYG OgoQ== X-Gm-Message-State: AOJu0YyLcM5tJXepASs+QlbpMkVdGU3R1UY4+iQhUy2Hfw9RdDx6mR6n PaHdKE3JRrd4m7/77hrd9nLDFg== X-Google-Smtp-Source: AGHT+IF++SrkXFK38Qj/F9y/LukAEEKLFdwReys5NfnrdSUHs8pNQlTgTge+TbQzhGVzZyJoZBj/Yw== X-Received: by 2002:a17:902:e5cd:b0:1b0:f8:9b2d with SMTP id u13-20020a170902e5cd00b001b000f89b2dmr23972880plf.29.1693029207746; Fri, 25 Aug 2023 22:53:27 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id f11-20020a170902ce8b00b001b694140d96sm2776475plg.170.2023.08.25.22.53.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 22:53:27 -0700 (PDT) Date: Sat, 26 Aug 2023 14:53:21 +0900 From: Sergey Senozhatsky To: Masahiro Yamada Cc: Sergey Senozhatsky , Ying Sun , Jesse T , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Jonathan Corbet , Tomasz Figa , linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] kconfig: introduce listunknownconfig Message-ID: <20230826055321.GF3913@google.com> References: <20230820024519.GK907732@google.com> <20230820072119.GM907732@google.com> <20230820073332.GN907732@google.com> <20230822061203.GA610023@google.com> <20230824012027.GD3913@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/08/26 14:38), Masahiro Yamada wrote: > > I am fine with implementing both. > > > > But, I'd like to implement them as separate options. > > (one option for warn unknown symbols, > > another for for turning warnings into errors) > > > > > > > > As I replied to Tomasz, I am considering about > > env variables vs command line options associated with W= option. > > > > With a little more thought, the command line option approach > would require more code changes and efforts. > Sounds good. > So, I am OK with adding new env variables. > Could you add two env variables? Absolutely. > I think > > the first two hunks (show warnings for symbols not found in Kconfig) > -> KCONFIG_WARN_UNKNOWN_SYMBOLS > > the last hunk (turn warnings into errors) > -> KCONFIG_WERROR > > (You can suggest a better naming if you have, but I guess > KCONFIG_WARN_* will be consistent in case > more warning requests come up.) Looks good. I'll send a patch in the coming days.