From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD44EC83F01 for ; Sat, 26 Aug 2023 17:03:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230387AbjHZRCb (ORCPT ); Sat, 26 Aug 2023 13:02:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbjHZRC1 (ORCPT ); Sat, 26 Aug 2023 13:02:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 170982115 for ; Sat, 26 Aug 2023 10:02:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A83362489 for ; Sat, 26 Aug 2023 17:02:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72A52C433CC; Sat, 26 Aug 2023 17:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1693069335; bh=b27lPrgYOlTBxvB3KFpTfXrDP07o9bRce16U2nOD30A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LWUOrUXoCfZROm3NtCrtJ0kTHSoHNbBTu7HQpspfgTslup16QiChMBByDPRq+8fRk bvfEfM/qPl4KeZnyOXkDZ/lJ8BsMKvbfySDmqb4/53LHdzoXZKrgEBkdB+EobQirB4 ZUbGq132f7bBg6fCfN4ux6VtcOhc2XNNpcvsdHuk= Date: Sat, 26 Aug 2023 19:02:12 +0200 From: Greg Kroah-Hartman To: Stanislav Kinsburskii Cc: Stanislav Kinsburskii , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Wei Liu , "K. Y. Srinivasan" , Madhavan Venkataraman , Anthony Yznaga , "Mike Rapoport (IBM)" , James Gowans , Anirudh Rayabharam , Jinank Jain , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] Introduce persistent memory pool Message-ID: <2023082620-saint-petition-bb89@gregkh> References: <64e7cbf7.050a0220.114c7.b70dSMTPIN_ADDED_BROKEN@mx.google.com> <2023082506-enchanted-tripping-d1d5@gregkh> <64e8f6dd.050a0220.edb3c.c045SMTPIN_ADDED_BROKEN@mx.google.com> <2023082633-magnetize-cupcake-accc@gregkh> <64ea25cd.650a0220.642cc.50e6SMTPIN_ADDED_BROKEN@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64ea25cd.650a0220.642cc.50e6SMTPIN_ADDED_BROKEN@mx.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2023 at 11:15:08PM -0700, Stanislav Kinsburskii wrote: > On Sat, Aug 26, 2023 at 09:45:39AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Aug 22, 2023 at 06:36:10PM -0700, Stanislav Kinsburskii wrote: > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#include > > > > > + > > > > > +#define VERSION 1 > > > > > > > > In kernel code does not need versions. > > > > > > > > > > Could you elaborate on this? Should kernel version be used as a backward > > > compatitbility marker instead? > > > > kernel versions should never be checked for in-kernel code, so I really > > don't understand the question here sorry. > > > > For code that is in the kernel tree, having "versions" on them (as many > > drivers used to, and now only a few do), makes no sense, especially with > > the stable/lts trees getting fixes for them over time as well. > > > > This version is rather an ABI version. The idea is to make sure, that > any future ABI change is explicit and reflected in the version, so it > can be easily noticed in case of kexec to a kernel with an older > version. > But I guess there are other ways to make sure, that the ABI contract is > the preserved. Which ABI are you referring to here. The user/kernel one? Or the kernel/hypervisor one? Or something else? There is no "numbering" of user/kernel apis, sorry. APIs just don't need that, you can handle things properly automatically without version numbers (as again, that just does not work.) thanks, greg k-h