* Re: [PATCH 4.14 00/57] 4.14.324-rc1 review
2023-08-28 10:12 [PATCH 4.14 00/57] 4.14.324-rc1 review Greg Kroah-Hartman
@ 2023-08-29 3:01 ` Daniel Díaz
2023-08-29 11:57 ` Nathan Lynch
2023-08-30 12:32 ` Greg Kroah-Hartman
2023-08-30 1:56 ` Guenter Roeck
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: Daniel Díaz @ 2023-08-29 3:01 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, nathanl, mpe
Hello!
On 28/08/23 4:12 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.324 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 30 Aug 2023 10:11:30 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.324-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
> Pseudo-Shortlog of commits:
>
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Linux 4.14.324-rc1
>
[...]
> Nathan Lynch <nathanl@linux.ibm.com>
> powerpc/rtas_flash: allow user copy to flash block cache objects
[...]
We see this build regression on PowerPC with GCC-8 and GCC-12:
-----8<-----
/builds/linux/arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_init':
/builds/linux/arch/powerpc/kernel/rtas_flash.c:717:22: error: implicit declaration of function 'kmem_cache_create_usercopy'; did you mean 'kmem_cache_create'? [-Werror=implicit-function-declaration]
flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
^~~~~~~~~~~~~~~~~~~~~~~~~~
kmem_cache_create
/builds/linux/arch/powerpc/kernel/rtas_flash.c:717:20: error: assignment to 'struct kmem_cache *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
^
----->8-----
That's on defconfig and cell_defconfig.
Bisection points to "powerpc/rtas_flash: allow user copy to flash block cache objects" (5190538c66e5). Reverting that patch makes the build pass again.
Tuxmake reproducer:
#pip3 install -U tuxmake
tuxmake --runtime podman --target-arch powerpc --toolchain gcc-8 --kconfig defconfig
git revert 5190538c66e5e8e7cdbf694afec8291f421e6bcf
tuxmake --runtime podman --target-arch powerpc --toolchain gcc-8 --kconfig defconfig
Greetings!
Daniel Díaz
daniel.diaz@linaro.org
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4.14 00/57] 4.14.324-rc1 review
2023-08-29 3:01 ` Daniel Díaz
@ 2023-08-29 11:57 ` Nathan Lynch
2023-08-30 12:32 ` Greg Kroah-Hartman
1 sibling, 0 replies; 8+ messages in thread
From: Nathan Lynch @ 2023-08-29 11:57 UTC (permalink / raw)
To: Daniel Díaz, Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, mpe
Daniel Díaz <daniel.diaz@linaro.org> writes:
>
> We see this build regression on PowerPC with GCC-8 and GCC-12:
> -----8<-----
> /builds/linux/arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_init':
> /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:22: error: implicit declaration of function 'kmem_cache_create_usercopy'; did you mean 'kmem_cache_create'? [-Werror=implicit-function-declaration]
> flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> kmem_cache_create
> /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:20: error: assignment to 'struct kmem_cache *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
> ^
> ----->8-----
>
> That's on defconfig and cell_defconfig.
>
> Bisection points to "powerpc/rtas_flash: allow user copy to flash
> block cache objects" (5190538c66e5). Reverting that patch makes the
> build pass again.
That change should not be applied to 4.14.x. The problem it fixes is not
present in that version.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4.14 00/57] 4.14.324-rc1 review
2023-08-29 3:01 ` Daniel Díaz
2023-08-29 11:57 ` Nathan Lynch
@ 2023-08-30 12:32 ` Greg Kroah-Hartman
1 sibling, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2023-08-30 12:32 UTC (permalink / raw)
To: Daniel Díaz
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, nathanl, mpe
On Mon, Aug 28, 2023 at 09:01:41PM -0600, Daniel Díaz wrote:
> Hello!
>
> On 28/08/23 4:12 a. m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.14.324 release.
> > There are 57 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 30 Aug 2023 10:11:30 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.324-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
> > -------------
> > Pseudo-Shortlog of commits:
> >
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Linux 4.14.324-rc1
> >
> [...]
> > Nathan Lynch <nathanl@linux.ibm.com>
> > powerpc/rtas_flash: allow user copy to flash block cache objects
> [...]
>
> We see this build regression on PowerPC with GCC-8 and GCC-12:
> -----8<-----
> /builds/linux/arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_init':
> /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:22: error: implicit declaration of function 'kmem_cache_create_usercopy'; did you mean 'kmem_cache_create'? [-Werror=implicit-function-declaration]
> flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> kmem_cache_create
> /builds/linux/arch/powerpc/kernel/rtas_flash.c:717:20: error: assignment to 'struct kmem_cache *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> flash_block_cache = kmem_cache_create_usercopy("rtas_flash_cache",
> ^
> ----->8-----
>
> That's on defconfig and cell_defconfig.
>
> Bisection points to "powerpc/rtas_flash: allow user copy to flash block cache objects" (5190538c66e5). Reverting that patch makes the build pass again.
Now dropped, thanks.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.14 00/57] 4.14.324-rc1 review
2023-08-28 10:12 [PATCH 4.14 00/57] 4.14.324-rc1 review Greg Kroah-Hartman
2023-08-29 3:01 ` Daniel Díaz
@ 2023-08-30 1:56 ` Guenter Roeck
2023-08-30 12:33 ` Greg Kroah-Hartman
2023-08-30 10:24 ` Jon Hunter
2023-08-30 11:31 ` Pavel Machek
3 siblings, 1 reply; 8+ messages in thread
From: Guenter Roeck @ 2023-08-30 1:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor
On Mon, Aug 28, 2023 at 12:12:20PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.324 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 30 Aug 2023 10:11:30 +0000.
> Anything received after that time might be too late.
>
Build results:
total: 139 pass: 133 fail: 6
Failed builds:
arm:ep93xx_defconfig
mips:mtx1_defconfig
mips:db1xxx_defconfig
powerpc:defconfig
powerpc:allmodconfig
powerpc:cell_defconfig
Qemu test results:
total: 431 pass: 414 fail: 17
Failed tests:
<all ppc64:pseries>
arm:ep93xx_defconfig
Error log:
arch/arm/mach-ep93xx/timer-ep93xx.c:12:10: fatal error: platform.h
That is really an older problem, caused by commit 2e50d55578b0 ("ARM:
ep93xx: fix missing-prototype warnings") which instead of fixing
anything in v4.14.y broke its build.
mips:mtx1_defconfig
arch/mips/alchemy/common/dbdma.c:33:10: fatal error: linux/dma-map-ops.h: No such file or directory
Again, an older problem, caused by commit 10130470bb0 ("MIPS: Alchemy:
fix dbdma2").
powerpc:defconfig, powerpc:allmodconfig, powerpc:cell_defconfig
arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_init':
arch/powerpc/kernel/rtas_flash.c:717:29: error: implicit declaration of function 'kmem_cache_create_usercopy'
ppc64 boot tests fail to compile with the same error.
Guenter
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4.14 00/57] 4.14.324-rc1 review
2023-08-30 1:56 ` Guenter Roeck
@ 2023-08-30 12:33 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2023-08-30 12:33 UTC (permalink / raw)
To: Guenter Roeck
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor
On Tue, Aug 29, 2023 at 06:56:51PM -0700, Guenter Roeck wrote:
> On Mon, Aug 28, 2023 at 12:12:20PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.14.324 release.
> > There are 57 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 30 Aug 2023 10:11:30 +0000.
> > Anything received after that time might be too late.
> >
>
> Build results:
> total: 139 pass: 133 fail: 6
> Failed builds:
> arm:ep93xx_defconfig
> mips:mtx1_defconfig
> mips:db1xxx_defconfig
> powerpc:defconfig
> powerpc:allmodconfig
> powerpc:cell_defconfig
> Qemu test results:
> total: 431 pass: 414 fail: 17
> Failed tests:
> <all ppc64:pseries>
>
> arm:ep93xx_defconfig
>
> Error log:
> arch/arm/mach-ep93xx/timer-ep93xx.c:12:10: fatal error: platform.h
>
> That is really an older problem, caused by commit 2e50d55578b0 ("ARM:
> ep93xx: fix missing-prototype warnings") which instead of fixing
> anything in v4.14.y broke its build.
>
> mips:mtx1_defconfig
>
> arch/mips/alchemy/common/dbdma.c:33:10: fatal error: linux/dma-map-ops.h: No such file or directory
>
> Again, an older problem, caused by commit 10130470bb0 ("MIPS: Alchemy:
> fix dbdma2").
Thanks, I'll work on these after this release.
> powerpc:defconfig, powerpc:allmodconfig, powerpc:cell_defconfig
>
> arch/powerpc/kernel/rtas_flash.c: In function 'rtas_flash_init':
> arch/powerpc/kernel/rtas_flash.c:717:29: error: implicit declaration of function 'kmem_cache_create_usercopy'
>
> ppc64 boot tests fail to compile with the same error.
This one is now dropped.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.14 00/57] 4.14.324-rc1 review
2023-08-28 10:12 [PATCH 4.14 00/57] 4.14.324-rc1 review Greg Kroah-Hartman
2023-08-29 3:01 ` Daniel Díaz
2023-08-30 1:56 ` Guenter Roeck
@ 2023-08-30 10:24 ` Jon Hunter
2023-08-30 11:31 ` Pavel Machek
3 siblings, 0 replies; 8+ messages in thread
From: Jon Hunter @ 2023-08-30 10:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, linux-tegra, stable
On Mon, 28 Aug 2023 12:12:20 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.324 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 30 Aug 2023 10:11:30 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.324-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
All tests passing for Tegra ...
Test results for stable-v4.14:
11 builds: 11 pass, 0 fail
16 boots: 16 pass, 0 fail
32 tests: 32 pass, 0 fail
Linux version: 4.14.324-rc1-g01b341fdf42f
Boards tested: tegra124-jetson-tk1, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Jon
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4.14 00/57] 4.14.324-rc1 review
2023-08-28 10:12 [PATCH 4.14 00/57] 4.14.324-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2023-08-30 10:24 ` Jon Hunter
@ 2023-08-30 11:31 ` Pavel Machek
3 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2023-08-30 11:31 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
Hi!
> This is the start of the stable review cycle for the 4.14.324 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.14.y
Tested-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread