From: Andrei Coardos <aboutphysycs@gmail.com>
To: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-riscv@lists.infradead.org
Cc: alex@shruggie.ro, herbert@gondor.apana.org.au,
olivia@selenic.com, daire.mcnamara@microchip.com,
conor.dooley@microchip.com,
Andrei Coardos <aboutphysycs@gmail.com>
Subject: [PATCH] char: hw_random: mpfs-rng: removed unneeded call to platform_set_drvdata()
Date: Mon, 28 Aug 2023 13:17:57 +0300 [thread overview]
Message-ID: <20230828101757.9724-1-aboutphysycs@gmail.com> (raw)
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/char/hw_random/mpfs-rng.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/hw_random/mpfs-rng.c b/drivers/char/hw_random/mpfs-rng.c
index c6972734ae62..0994024daa70 100644
--- a/drivers/char/hw_random/mpfs-rng.c
+++ b/drivers/char/hw_random/mpfs-rng.c
@@ -79,8 +79,6 @@ static int mpfs_rng_probe(struct platform_device *pdev)
rng_priv->rng.read = mpfs_rng_read;
rng_priv->rng.name = pdev->name;
- platform_set_drvdata(pdev, rng_priv);
-
ret = devm_hwrng_register(&pdev->dev, &rng_priv->rng);
if (ret)
return dev_err_probe(&pdev->dev, ret, "Failed to register MPFS hwrng\n");
--
2.34.1
next reply other threads:[~2023-08-28 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 10:17 Andrei Coardos [this message]
2023-08-28 11:03 ` [PATCH] char: hw_random: mpfs-rng: removed unneeded call to platform_set_drvdata() Conor Dooley
2023-09-01 6:07 ` Alexandru Ardelean
2023-09-01 6:25 ` Conor Dooley
2023-09-15 10:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828101757.9724-1-aboutphysycs@gmail.com \
--to=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=olivia@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox