* [PATCH] char: hw_random: xgene-rng: removed unneeded call to platform_set_drvdata()
@ 2023-08-28 10:23 Andrei Coardos
2023-08-28 11:48 ` Martin Kaiser
2023-09-15 10:38 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Andrei Coardos @ 2023-08-28 10:23 UTC (permalink / raw)
To: linux-kernel, linux-crypto
Cc: yuzhe, u.kleine-koenig, herbert, olivia, alex, Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/char/hw_random/xgene-rng.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
index 7c8f3cb7c6af..9d64b5931a27 100644
--- a/drivers/char/hw_random/xgene-rng.c
+++ b/drivers/char/hw_random/xgene-rng.c
@@ -321,7 +321,6 @@ static int xgene_rng_probe(struct platform_device *pdev)
return -ENOMEM;
ctx->dev = &pdev->dev;
- platform_set_drvdata(pdev, ctx);
ctx->csr_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ctx->csr_base))
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] char: hw_random: xgene-rng: removed unneeded call to platform_set_drvdata()
2023-08-28 10:23 [PATCH] char: hw_random: xgene-rng: removed unneeded call to platform_set_drvdata() Andrei Coardos
@ 2023-08-28 11:48 ` Martin Kaiser
2023-09-01 6:09 ` Alexandru Ardelean
2023-09-15 10:38 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Martin Kaiser @ 2023-08-28 11:48 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-crypto, yuzhe, u.kleine-koenig, herbert,
olivia, alex
Andrei Coardos (aboutphysycs@gmail.com) wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/char/hw_random/xgene-rng.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
> index 7c8f3cb7c6af..9d64b5931a27 100644
> --- a/drivers/char/hw_random/xgene-rng.c
> +++ b/drivers/char/hw_random/xgene-rng.c
> @@ -321,7 +321,6 @@ static int xgene_rng_probe(struct platform_device *pdev)
> return -ENOMEM;
> ctx->dev = &pdev->dev;
> - platform_set_drvdata(pdev, ctx);
> ctx->csr_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ctx->csr_base))
> --
> 2.34.1
This one's ok, too. 67fb1e295839 ("hwrng: xgene - Simplify using
devm_clk_get_optional_enabled()") removed the platform_get_drvdata call.
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] char: hw_random: xgene-rng: removed unneeded call to platform_set_drvdata()
2023-08-28 11:48 ` Martin Kaiser
@ 2023-09-01 6:09 ` Alexandru Ardelean
0 siblings, 0 replies; 4+ messages in thread
From: Alexandru Ardelean @ 2023-09-01 6:09 UTC (permalink / raw)
To: Martin Kaiser
Cc: Andrei Coardos, linux-kernel, linux-crypto, yuzhe,
u.kleine-koenig, herbert, olivia
On Mon, Aug 28, 2023 at 2:48 PM Martin Kaiser <lists@kaiser.cx> wrote:
>
> Andrei Coardos (aboutphysycs@gmail.com) wrote:
>
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
>
> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> > ---
> > drivers/char/hw_random/xgene-rng.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> > diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
> > index 7c8f3cb7c6af..9d64b5931a27 100644
> > --- a/drivers/char/hw_random/xgene-rng.c
> > +++ b/drivers/char/hw_random/xgene-rng.c
> > @@ -321,7 +321,6 @@ static int xgene_rng_probe(struct platform_device *pdev)
> > return -ENOMEM;
>
> > ctx->dev = &pdev->dev;
> > - platform_set_drvdata(pdev, ctx);
>
> > ctx->csr_base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(ctx->csr_base))
> > --
> > 2.34.1
>
> This one's ok, too. 67fb1e295839 ("hwrng: xgene - Simplify using
> devm_clk_get_optional_enabled()") removed the platform_get_drvdata call.
>
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Reviewed-by: Martin Kaiser <martin@kaiser.cx>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] char: hw_random: xgene-rng: removed unneeded call to platform_set_drvdata()
2023-08-28 10:23 [PATCH] char: hw_random: xgene-rng: removed unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-28 11:48 ` Martin Kaiser
@ 2023-09-15 10:38 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2023-09-15 10:38 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-crypto, yuzhe, u.kleine-koenig, olivia, alex
On Mon, Aug 28, 2023 at 01:23:29PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/char/hw_random/xgene-rng.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-15 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 10:23 [PATCH] char: hw_random: xgene-rng: removed unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-28 11:48 ` Martin Kaiser
2023-09-01 6:09 ` Alexandru Ardelean
2023-09-15 10:38 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox