public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrei Coardos <aboutphysycs@gmail.com>
To: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, olivia@selenic.com,
	alex@shruggie.ro, Andrei Coardos <aboutphysycs@gmail.com>
Subject: [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata()
Date: Mon, 28 Aug 2023 13:29:43 +0300	[thread overview]
Message-ID: <20230828102943.21097-1-aboutphysycs@gmail.com> (raw)

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/char/hw_random/xiphera-trng.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/char/hw_random/xiphera-trng.c b/drivers/char/hw_random/xiphera-trng.c
index 2a9fea72b2e0..1fa4b70246f0 100644
--- a/drivers/char/hw_random/xiphera-trng.c
+++ b/drivers/char/hw_random/xiphera-trng.c
@@ -122,8 +122,6 @@ static int xiphera_trng_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	platform_set_drvdata(pdev, trng);
-
 	return 0;
 }
 
-- 
2.34.1


             reply	other threads:[~2023-08-28 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 10:29 Andrei Coardos [this message]
2023-09-01  6:04 ` [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata() Alexandru Ardelean
2023-09-01  6:10   ` Alexandru Ardelean
2023-09-15 10:38 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230828102943.21097-1-aboutphysycs@gmail.com \
    --to=aboutphysycs@gmail.com \
    --cc=alex@shruggie.ro \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olivia@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox