* [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata()
@ 2023-08-28 10:29 Andrei Coardos
2023-09-01 6:04 ` Alexandru Ardelean
2023-09-15 10:38 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Andrei Coardos @ 2023-08-28 10:29 UTC (permalink / raw)
To: linux-kernel, linux-crypto; +Cc: herbert, olivia, alex, Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/char/hw_random/xiphera-trng.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/hw_random/xiphera-trng.c b/drivers/char/hw_random/xiphera-trng.c
index 2a9fea72b2e0..1fa4b70246f0 100644
--- a/drivers/char/hw_random/xiphera-trng.c
+++ b/drivers/char/hw_random/xiphera-trng.c
@@ -122,8 +122,6 @@ static int xiphera_trng_probe(struct platform_device *pdev)
return ret;
}
- platform_set_drvdata(pdev, trng);
-
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata()
2023-08-28 10:29 [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata() Andrei Coardos
@ 2023-09-01 6:04 ` Alexandru Ardelean
2023-09-01 6:10 ` Alexandru Ardelean
2023-09-15 10:38 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Alexandru Ardelean @ 2023-09-01 6:04 UTC (permalink / raw)
To: Andrei Coardos; +Cc: linux-kernel, linux-crypto, herbert, olivia
On Mon, Aug 28, 2023 at 1:29 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/char/hw_random/xiphera-trng.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/hw_random/xiphera-trng.c b/drivers/char/hw_random/xiphera-trng.c
> index 2a9fea72b2e0..1fa4b70246f0 100644
> --- a/drivers/char/hw_random/xiphera-trng.c
> +++ b/drivers/char/hw_random/xiphera-trng.c
> @@ -122,8 +122,6 @@ static int xiphera_trng_probe(struct platform_device *pdev)
> return ret;
> }
>
> - platform_set_drvdata(pdev, trng);
> -
> return 0;
This entire block could become now:
return devm_hwrng_register(dev, &trng->rng);
> }
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata()
2023-09-01 6:04 ` Alexandru Ardelean
@ 2023-09-01 6:10 ` Alexandru Ardelean
0 siblings, 0 replies; 4+ messages in thread
From: Alexandru Ardelean @ 2023-09-01 6:10 UTC (permalink / raw)
To: Andrei Coardos; +Cc: linux-kernel, linux-crypto, herbert, olivia
On Fri, Sep 1, 2023 at 9:04 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> On Mon, Aug 28, 2023 at 1:29 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
> >
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
> >
> > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> > ---
> > drivers/char/hw_random/xiphera-trng.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/char/hw_random/xiphera-trng.c b/drivers/char/hw_random/xiphera-trng.c
> > index 2a9fea72b2e0..1fa4b70246f0 100644
> > --- a/drivers/char/hw_random/xiphera-trng.c
> > +++ b/drivers/char/hw_random/xiphera-trng.c
> > @@ -122,8 +122,6 @@ static int xiphera_trng_probe(struct platform_device *pdev)
> > return ret;
> > }
> >
> > - platform_set_drvdata(pdev, trng);
> > -
> > return 0;
>
> This entire block could become now:
>
> return devm_hwrng_register(dev, &trng->rng);
>
Coming back here.
I wonder if there is a desire to keep the prints above.
If yes, then this is fine as-is.
With that:
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> > }
> >
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata()
2023-08-28 10:29 [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata() Andrei Coardos
2023-09-01 6:04 ` Alexandru Ardelean
@ 2023-09-15 10:38 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2023-09-15 10:38 UTC (permalink / raw)
To: Andrei Coardos; +Cc: linux-kernel, linux-crypto, olivia, alex
On Mon, Aug 28, 2023 at 01:29:43PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/char/hw_random/xiphera-trng.c | 2 --
> 1 file changed, 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-15 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 10:29 [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata() Andrei Coardos
2023-09-01 6:04 ` Alexandru Ardelean
2023-09-01 6:10 ` Alexandru Ardelean
2023-09-15 10:38 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox