public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <brendan.higgins@linux.dev>, <davidgow@google.com>, <rmoar@google.com>
Cc: <linux-kselftest@vger.kernel.org>, <kunit-dev@googlegroups.com>,
	<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>
Subject: [PATCH v6 00/10] kunit: Add dynamically-extending log
Date: Mon, 28 Aug 2023 11:41:01 +0100	[thread overview]
Message-ID: <20230828104111.2394344-1-rf@opensource.cirrus.com> (raw)

This patch chain changes the logging implementation to use string_stream
so that the log will grow dynamically.

The first 8 patches add test code for string_stream, and make some
changes to string_stream needed to be able to use it for the log.

The final patch adds a performance report of string_stream.

CHANGES SINCE V5:
Patch 2:
- Avoid cast warning when using KUNIT_EXPECT_EQ() on a gfp_t. Instead pass
  the result of the comparison to KUNIT_EXPECT_TRUE(). While it would be
  nice to use KUNIT_EXPECT_EQ(), it's probably better to avoid introducing
  build or sparse warnings.

- In string_stream_append_test() rename original_content to
  stream1_content_before_append.

Patch 7:
- Make string_stream_clear() public (in v5 this was done in patch #8).
- In string-stream-test.c add a wrapper for kfree() to prevent a cast
  warning when calling kunit_add_action().

Patch 8:
- Fix memory leak when calling the redirected string_stream_destroy_stub().

Patch 9:
- In kunit-test.c: add wrapper function around kfree() to prevent cast
  warning when calling kunit_add_action().
- Fix unused variable warning in kunit_log_test() when built as a module.

Richard Fitzgerald (10):
  kunit: string-stream: Don't create a fragment for empty strings
  kunit: string-stream: Improve testing of string_stream
  kunit: string-stream: Add option to make all lines end with newline
  kunit: string-stream-test: Add cases for string_stream newline
    appending
  kunit: Don't use a managed alloc in is_literal()
  kunit: string-stream: Add kunit_alloc_string_stream()
  kunit: string-stream: Decouple string_stream from kunit
  kunit: string-stream: Add tests for freeing resource-managed
    string_stream
  kunit: Use string_stream for test log
  kunit: string-stream: Test performance of string_stream

 include/kunit/test.h           |  14 +-
 lib/kunit/assert.c             |  14 +-
 lib/kunit/debugfs.c            |  36 ++-
 lib/kunit/kunit-test.c         |  56 +++-
 lib/kunit/string-stream-test.c | 525 +++++++++++++++++++++++++++++++--
 lib/kunit/string-stream.c      | 100 +++++--
 lib/kunit/string-stream.h      |  16 +-
 lib/kunit/test.c               |  50 +---
 8 files changed, 688 insertions(+), 123 deletions(-)

-- 
2.30.2


             reply	other threads:[~2023-08-28 10:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 10:41 Richard Fitzgerald [this message]
2023-08-28 10:41 ` [PATCH v6 01/10] kunit: string-stream: Don't create a fragment for empty strings Richard Fitzgerald
2023-08-28 10:41 ` [PATCH v6 02/10] kunit: string-stream: Improve testing of string_stream Richard Fitzgerald
2023-08-28 10:41 ` [PATCH v6 03/10] kunit: string-stream: Add option to make all lines end with newline Richard Fitzgerald
2023-08-28 10:41 ` [PATCH v6 04/10] kunit: string-stream-test: Add cases for string_stream newline appending Richard Fitzgerald
2023-08-28 10:41 ` [PATCH v6 05/10] kunit: Don't use a managed alloc in is_literal() Richard Fitzgerald
2023-08-28 10:41 ` [PATCH v6 06/10] kunit: string-stream: Add kunit_alloc_string_stream() Richard Fitzgerald
2023-08-28 10:41 ` [PATCH v6 07/10] kunit: string-stream: Decouple string_stream from kunit Richard Fitzgerald
2023-08-28 10:41 ` [PATCH v6 08/10] kunit: string-stream: Add tests for freeing resource-managed string_stream Richard Fitzgerald
2023-09-02  8:24   ` David Gow
2023-08-28 10:41 ` [PATCH v6 09/10] kunit: Use string_stream for test log Richard Fitzgerald
2023-08-28 10:41 ` [PATCH v6 10/10] kunit: string-stream: Test performance of string_stream Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230828104111.2394344-1-rf@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=brendan.higgins@linux.dev \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rmoar@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox