From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45ABC83F1C for ; Mon, 28 Aug 2023 10:58:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232303AbjH1K6E (ORCPT ); Mon, 28 Aug 2023 06:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232428AbjH1K5Y (ORCPT ); Mon, 28 Aug 2023 06:57:24 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51667FC; Mon, 28 Aug 2023 03:57:15 -0700 (PDT) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B7FA16B5; Mon, 28 Aug 2023 12:55:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693220152; bh=VTzca3iUwehGexR3ipQh5zY59SSh8Zb9GlneapDtzvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q0xvoHZ9jnqG/CU3/9oI8sF1KNeReV0qgbJvY7IGwKeBSOg/jAG/DkO+xJF5pbH4B as+te2Zo+cwMIoy3XSxYV6GUrksSm/q87eWp9EfFuYnhrCdSfmpmTTsQYBi9/NSTNF FxB1rUxC5ZYsvRc49xQWceabILNDmtkrFur4ngTQ= Date: Mon, 28 Aug 2023 13:57:23 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: Christophe JAILLET , Jacopo Mondi , Kieran Bingham , Niklas =?utf-8?Q?S=C3=B6derlund?= , Mauro Carvalho Chehab , Sakari Ailus , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] media: i2c: rdacm2: Remove an incorrect fwnode_handle_put() call Message-ID: <20230828105723.GF14596@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 28, 2023 at 09:48:10AM +0200, Jacopo Mondi wrote: > Hi Christophe > > On Sat, Aug 26, 2023 at 10:05:06AM +0200, Christophe JAILLET wrote: > > The commit in Fixes has removed an fwnode_handle_put() call in the error > > handling path of the probe. > > > > Remove the same call from the remove function. > > > > Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching") > > Signed-off-by: Christophe JAILLET > > Reviewed-by: Jacopo Mondi The subject line should read "rdacm21", not "rdacm2". with that fixed, Reviewed-by: Laurent Pinchart > > --- > > /!\ This patch is highly speculative. Review with care. /!\ > > > > If it is correct, it is likely that other similar issue lurk in commit > > 1029939b3782. I've not looked in detail and my cocci script did not > > trigger on them but drivers/media/i2c/max9286.c also looks like a > > similar candidate. > > I think the call to fwnode_handle_put(priv->sd.fwnode) in > max9286_v4l2_unregister() can indeed be removed, yes! I agree. > > --- > > drivers/media/i2c/rdacm21.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c > > index a36a709243fd..3e22df36354f 100644 > > --- a/drivers/media/i2c/rdacm21.c > > +++ b/drivers/media/i2c/rdacm21.c > > @@ -608,7 +608,6 @@ static void rdacm21_remove(struct i2c_client *client) > > v4l2_async_unregister_subdev(&dev->sd); > > v4l2_ctrl_handler_free(&dev->ctrls); > > i2c_unregister_device(dev->isp); > > - fwnode_handle_put(dev->sd.fwnode); > > } > > > > static const struct of_device_id rdacm21_of_ids[] = { -- Regards, Laurent Pinchart