Re: [PATCH v3 04/15] media: qcom: camss: Pass remainder of variables as resources

Konrad Dybcio
2023-08-26T09:58:26Z

On 23.08.2023 12:44, Bryan O'Donoghue wrote:
> The following variables are being assigned statically based on
> compatible strings in the probe path.
>
> * enum camss_version version;
> * int csiphy_num;
> * int csid_num;
> * int vfe_num;
> * int vfe_lite_num;
> * int vfe_total_num;
>
> Migrate those variables to resource parameters passed in on platform
> probe arguments. The one caveat is for VFE it has been necessary to
> intoduce a new variable vfe_total_num to capture the aggregate value of
> vfe_num + vfe_lite_num.
>
> All the rest of the changes are rote camss->variable to
> camss->res->variable with the parameter tables now populating the listed
> variables.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
I don't see anything immediately wrong. This was long necessary!

Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad