From: Kees Cook <keescook@chromium.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
Enlin Mu <enlin.mu@unisoc.com>,
Eric Biggers <ebiggers@google.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Yunlong Xing <yunlong.xing@unisoc.com>,
Yuxiao Zhang <yuxiaozhang@google.com>
Subject: Re: [GIT PULL] pstore updates for v6.6-rc1
Date: Mon, 28 Aug 2023 20:44:34 -0700 [thread overview]
Message-ID: <202308282035.5AFD431B@keescook> (raw)
In-Reply-To: <CAHk-=wjRD_LnCbwSRM20Fg54xhrFBLwgO=X23bdconx3wKokxg@mail.gmail.com>
On Mon, Aug 28, 2023 at 06:44:02PM -0700, Linus Torvalds wrote:
> The only thing that is new is the kernel pstore implementation. Why
> was this not a problem before? The warning existed back then too, but
> I never actually got it.
Right -- if the compression method from before was different, it'll fail
now. (i.e. we removed everything but zlib.)
> I get the feeling that you are overlooking that basic fact.
That's why I was wondering about the prior config; it could confirm the
default compression algo. But digging around it seems like zlib is the
default in the F37 kernel config. I'll keep looking; there is clearly
some combination I don't know.
I remain concerned about why there are 124. That's a LOT, and without
prior warnings, I don't know why systemd-pstore wasn't removing them.
Can you send me "ls -la /sys/fs/pstore" ? Maybe they aren't a dump type
that systemd knows about.
I will try to reproduce this with an F37 image...
--
Kees Cook
next prev parent reply other threads:[~2023-08-29 3:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 18:21 [GIT PULL] pstore updates for v6.6-rc1 Kees Cook
2023-08-28 20:15 ` pr-tracker-bot
2023-08-28 23:56 ` Linus Torvalds
2023-08-29 1:28 ` Kees Cook
2023-08-29 1:44 ` Linus Torvalds
2023-08-29 3:44 ` Kees Cook [this message]
2023-08-29 17:13 ` Linus Torvalds
2023-08-29 17:29 ` Ard Biesheuvel
2023-08-29 18:03 ` Linus Torvalds
2023-08-29 21:43 ` Ard Biesheuvel
2023-08-30 6:05 ` Eric Biggers
2023-08-30 7:48 ` Ard Biesheuvel
2023-08-30 17:00 ` Kees Cook
2023-08-30 9:10 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308282035.5AFD431B@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=ebiggers@google.com \
--cc=enlin.mu@unisoc.com \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=yunlong.xing@unisoc.com \
--cc=yuxiaozhang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox