From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0987FC83F1F for ; Tue, 29 Aug 2023 13:35:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231576AbjH2Nfc (ORCPT ); Tue, 29 Aug 2023 09:35:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236247AbjH2Ne4 (ORCPT ); Tue, 29 Aug 2023 09:34:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E1FC1AC; Tue, 29 Aug 2023 06:34:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E6AE657B6; Tue, 29 Aug 2023 13:34:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1E9EC433CA; Tue, 29 Aug 2023 13:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693316041; bh=iAWbAWMjPdGDW7CK7g8a2Au+8MJJNfpI7uyNufJ+vJw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uF2IDtOIhEBxm4GMJfMjuD3yo4vCDlzPbi48Y2lkrqgVscYeW2zjHEQr8YpbHZbvW p5v7gotjTuwKgGzcCggaG7rTE3OlANLsne/D8IhzS7etoWcNzlrXZKkPcF9EG2gySd PRSpBzCCdlkKFYmAGxkpzgLKUwjydoAM6UmKU4Vg5S29FFXFf/i16EasKVYPUN1yTp Ce9ZXvaIYuS+b84JJg0lv49uPgAg4HYHJYyMT2e3aQgFztYMxENPgzdSzVzaJPIkUs 3JjDUoMWo0aPWhu7L539P1DYtXhzDBMDRMbV9WC6m1sM9vYEvXLnz2DsvxWs4RQBFH HL/tEqGSrMHxg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shyam Prasad N , Bharath SM , Steve French , Sasha Levin , pc@cjr.nz, gregkh@linuxfoundation.org, lsahlber@redhat.com, pc@manguebit.com, vl@samba.org, ematsumiya@suse.de Subject: [PATCH AUTOSEL 5.4 4/6] cifs: add a warning when the in-flight count goes negative Date: Tue, 29 Aug 2023 09:33:50 -0400 Message-Id: <20230829133352.520671-4-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230829133352.520671-1-sashal@kernel.org> References: <20230829133352.520671-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.254 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shyam Prasad N [ Upstream commit e4645cc2f1e2d6f268bb8dcfac40997c52432aed ] We've seen the in-flight count go into negative with some internal stress testing in Microsoft. Adding a WARN when this happens, in hope of understanding why this happens when it happens. Signed-off-by: Shyam Prasad N Reviewed-by: Bharath SM Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/smb2ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index cd0030533bf7a..ad9b207432e10 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -79,6 +79,7 @@ smb2_add_credits(struct TCP_Server_Info *server, *val = 65000; /* Don't get near 64K credits, avoid srv bugs */ printk_once(KERN_WARNING "server overflowed SMB3 credits\n"); } + WARN_ON_ONCE(server->in_flight == 0); server->in_flight--; if (server->in_flight == 0 && (optype & CIFS_OP_MASK) != CIFS_NEG_OP) rc = change_conf(server); -- 2.40.1