From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE48EC83F26 for ; Tue, 29 Aug 2023 13:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236505AbjH2NgG (ORCPT ); Tue, 29 Aug 2023 09:36:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236533AbjH2NfF (ORCPT ); Tue, 29 Aug 2023 09:35:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B867A10EB; Tue, 29 Aug 2023 06:34:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21AB965854; Tue, 29 Aug 2023 13:34:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40282C433C9; Tue, 29 Aug 2023 13:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693316068; bh=uXmaPFhvW8kp7u25pEhdup797SiPTowQUVoF0QRyaoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rAdOfNje/LBjia7vHotsn3rrIvSuptPo5MkpL57+oYLmUnysLgRrr0YP1wAumF9Gj JEuOzbQ6NS1xNtZwOlvailUoErqDU4Y5J/OBM831bpekeJBVupSy6XSfW72NEAz+fp 6noPRx5BBIK95XAQMHw6uUzkCCazUiAfb9o0vPZ6eG1EQZo8sw2snyHbvKKjillIxB tNsHLMSrXSR2q5UPlfBmQZVpzC2VQK7avkEX7/KMS3IxDTkoh6I8CPLb4BllV/5BTj Dc47RWyd3iiM84F6Ya8In8PDNSQoG13gL5ZlK+hR08ZLrwhQ3x81XwYxo9NOtzOF13 LvGGNW9M62L1A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shyam Prasad N , Bharath SM , Steve French , Sasha Levin , pc@cjr.nz, gregkh@linuxfoundation.org, lsahlber@redhat.com, pc@manguebit.com, vl@samba.org, abelova@astralinux.ru Subject: [PATCH AUTOSEL 4.14 4/5] cifs: add a warning when the in-flight count goes negative Date: Tue, 29 Aug 2023 09:34:17 -0400 Message-Id: <20230829133419.520830-4-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230829133419.520830-1-sashal@kernel.org> References: <20230829133419.520830-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.323 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shyam Prasad N [ Upstream commit e4645cc2f1e2d6f268bb8dcfac40997c52432aed ] We've seen the in-flight count go into negative with some internal stress testing in Microsoft. Adding a WARN when this happens, in hope of understanding why this happens when it happens. Signed-off-by: Shyam Prasad N Reviewed-by: Bharath SM Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/smb2ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index dec306a3b0f41..3287795c648e5 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -78,6 +78,7 @@ smb2_add_credits(struct TCP_Server_Info *server, const unsigned int add, *val = 65000; /* Don't get near 64K credits, avoid srv bugs */ printk_once(KERN_WARNING "server overflowed SMB3 credits\n"); } + WARN_ON_ONCE(server->in_flight == 0); server->in_flight--; if (server->in_flight == 0 && (optype & CIFS_OP_MASK) != CIFS_NEG_OP) rc = change_conf(server); -- 2.40.1