From: Steven Rostedt <rostedt@goodmis.org>
To: SeongJae Park <sj@kernel.org>
Cc: damon@lists.linux.dev, Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm/damon/core: add a tracepoint for damos apply target regions
Date: Tue, 29 Aug 2023 19:16:29 -0400 [thread overview]
Message-ID: <20230829191629.25c5f0e2@rorschach.local.home> (raw)
In-Reply-To: <20230827004045.49516-1-sj@kernel.org>
On Sun, 27 Aug 2023 00:40:45 +0000
SeongJae Park <sj@kernel.org> wrote:
> + TP_STRUCT__entry(
> + __field(unsigned int, context_idx)
4 bytes
> + __field(unsigned int, scheme_idx)
4 bytes
> + __field(unsigned long, target_idx)
8 bytes
> + __field(unsigned int, nr_regions)
4 bytes
> + __field(unsigned long, start)
This is going to cause a 4 byte hole. I would move nr_regions after end
so that it stays properly aligned.
-- Steve
> + __field(unsigned long, end)
> + __field(unsigned int, nr_accesses)
> + __field(unsigned int, age)
> + ),
> +
next prev parent reply other threads:[~2023-08-29 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 0:40 [RFC PATCH] mm/damon/core: add a tracepoint for damos apply target regions SeongJae Park
2023-08-29 23:16 ` Steven Rostedt [this message]
2023-08-30 1:36 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829191629.25c5f0e2@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox