From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E05C4C83F12 for ; Tue, 29 Aug 2023 20:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239169AbjH2U02 (ORCPT ); Tue, 29 Aug 2023 16:26:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239317AbjH2U0S (ORCPT ); Tue, 29 Aug 2023 16:26:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7029EE9 for ; Tue, 29 Aug 2023 13:26:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0578B61354 for ; Tue, 29 Aug 2023 20:26:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0675CC433C7; Tue, 29 Aug 2023 20:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693340775; bh=evqOhXviBKef3wu6rsLB7EURzchx4hr5qk+q8Fuv6tQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=lNLIJK0HooSnG9N+FCLEm25TYYxzm2WcIyzombUj4vPlYJUtxhrY3tGHasjP84mm/ 8quK5STOd/PcX+KsJVtwQkcn6WI4tWP2k8EHryPumN5Bdo51C83yO+rmMG7ZpJlEdL 59ZJgCsi8A5rrcx6gJZEMXQL3v+DDDmaBqQDgVFYRyoihLMMjHjmKYQG4IGgaIElQe MEFeyu6zSlUNyQg6qIbw1zD/IY9jgI0o/FQfQiBoeg4KawKVT+H5OgZOu7UO4d0p0D ClP0/RpExoG8wBGRdS46bBSlmedeNoTS85NHlS4VvcK9FHTASt2aK6nbfweW8e27U1 jh2nLs9vWkUkw== Date: Tue, 29 Aug 2023 15:26:13 -0500 From: Bjorn Helgaas To: Valentin Sinitsyn Cc: kernel test robot , Greg Kroah-Hartman , Tejun Heo , oe-kbuild-all@lists.linux.dev, Daniel Vetter , Dan Williams , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] PCI: Implement custom llseek for sysfs resource entries Message-ID: <20230829202613.GA807744@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829200229.GA804314@bhelgaas> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2023 at 03:02:29PM -0500, Bjorn Helgaas wrote: > On Mon, Aug 28, 2023 at 12:22:54PM +0500, Valentin Sinitsyn wrote: > > On 25.08.2023 19:10, kernel test robot wrote: > > > Hi Valentine, > > > > > > kernel test robot noticed the following build warnings: > > > > > [..] > > > All warnings (new ones prefixed by >>): > > > > > > drivers/pci/pci-sysfs.c:1268:12: warning: no previous prototype for 'pci_create_resource_files' [-Wmissing-prototypes] > > > 1268 | int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; } > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > drivers/pci/pci-sysfs.c:1269:13: warning: no previous prototype for 'pci_remove_resource_files' [-Wmissing-prototypes] > > > 1269 | void __weak pci_remove_resource_files(struct pci_dev *dev) { return; } > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > drivers/pci/pci-sysfs.c:838:15: warning: 'pci_llseek_resource' defined but not used [-Wunused-function] > > > 838 | static loff_t pci_llseek_resource(struct file *filep, > > > | ^~~~~~~~~~~~~~~~~~~ > > I'm not sure if I should do anything about it: arc doesn't HAVE_* anything > > PCI-related, and pci-sysfs doesn't seem to be written with this case in > > mind. Guarding pci_llseek_resource() with an #ifdef HAVE_AT_LEAST_SOMETHING > > is trivial, but it feels more like a patch to silence a bot than a proper > > fix. > > Looks like it will require some untangling to figure out a nice fix, > but I think you *do* need to do something about it because I don't > want to add build errors on any arch. P.S. This patch: https://lore.kernel.org/r/20230810141947.1236730-5-arnd@kernel.org is queued up for v6.6-rc1 and should help with the first two warnings. Bjorn