public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: cadence: remove unused cdns_plat_pcie->is_rc
@ 2023-07-05 10:15 Li Chen
  2023-08-30  9:07 ` "Krzysztof Wilczyński"
  0 siblings, 1 reply; 2+ messages in thread
From: Li Chen @ 2023-07-05 10:15 UTC (permalink / raw)
  To: Tom Joseph, Lorenzo Pieralisi,
	"Krzysztof Wilczyński", Rob Herring, Bjorn Helgaas,
	linux-kernel, linux-pci

We already have cdns_plat_pcie_of_data->is_rc.

Signed-off-by: Li Chen <lchen@ambarella.com>
---
 drivers/pci/controller/cadence/pcie-cadence-plat.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/pci/controller/cadence/pcie-cadence-plat.c
index bac0541317c1..e091fef9c919 100644
--- a/drivers/pci/controller/cadence/pcie-cadence-plat.c
+++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c
@@ -18,12 +18,9 @@
 /**
  * struct cdns_plat_pcie - private data for this PCIe platform driver
  * @pcie: Cadence PCIe controller
- * @is_rc: Set to 1 indicates the PCIe controller mode is Root Complex,
- *         if 0 it is in Endpoint mode.
  */
 struct cdns_plat_pcie {
 	struct cdns_pcie        *pcie;
-	bool is_rc;
 };
 
 struct cdns_plat_pcie_of_data {
@@ -77,7 +74,6 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
 		rc->pcie.dev = dev;
 		rc->pcie.ops = &cdns_plat_ops;
 		cdns_plat_pcie->pcie = &rc->pcie;
-		cdns_plat_pcie->is_rc = is_rc;
 
 		ret = cdns_pcie_init_phy(dev, cdns_plat_pcie->pcie);
 		if (ret) {
@@ -105,7 +101,6 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
 		ep->pcie.dev = dev;
 		ep->pcie.ops = &cdns_plat_ops;
 		cdns_plat_pcie->pcie = &ep->pcie;
-		cdns_plat_pcie->is_rc = is_rc;
 
 		ret = cdns_pcie_init_phy(dev, cdns_plat_pcie->pcie);
 		if (ret) {
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: cadence: remove unused cdns_plat_pcie->is_rc
  2023-07-05 10:15 [PATCH] PCI: cadence: remove unused cdns_plat_pcie->is_rc Li Chen
@ 2023-08-30  9:07 ` "Krzysztof Wilczyński"
  0 siblings, 0 replies; 2+ messages in thread
From: "Krzysztof Wilczyński" @ 2023-08-30  9:07 UTC (permalink / raw)
  To: Li Chen
  Cc: Tom Joseph, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas,
	linux-kernel, linux-pci

Hello,

> We already have cdns_plat_pcie_of_data->is_rc.

Applied to controller/cadence, thank you!

[1/1] PCI: cadence: Drop unused member from struct cdns_plat_pcie
      https://git.kernel.org/pci/pci/c/abc6119edfe8

	Krzysztof

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-30 19:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-05 10:15 [PATCH] PCI: cadence: remove unused cdns_plat_pcie->is_rc Li Chen
2023-08-30  9:07 ` "Krzysztof Wilczyński"

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox