From: Kees Cook <keescook@chromium.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, Enlin Mu <enlin.mu@unisoc.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Yunlong Xing <yunlong.xing@unisoc.com>,
Yuxiao Zhang <yuxiaozhang@google.com>
Subject: Re: [GIT PULL] pstore updates for v6.6-rc1
Date: Wed, 30 Aug 2023 10:00:43 -0700 [thread overview]
Message-ID: <202308300957.BCD878259@keescook> (raw)
In-Reply-To: <CAMj1kXGZ11VS=Tr8i5oKsdXkAuGt+k5GLUvVqzrYBg6UEs=HQA@mail.gmail.com>
On Wed, Aug 30, 2023 at 09:48:48AM +0200, Ard Biesheuvel wrote:
> In any case, I'll rate limit the error so it doesn't clutter up the logs.
Great; thanks for looking at it!
A related issue I'm going to tackle is dealing with the risk of
ever-growing record counts for backends that don't treat their storage
as a circular buffer. (e.g. ramoops will overwrite the latest record
when it runs out of empty areas, but EFI will just keep on writing new
records.) It's clear we can't depend on userspace to do this clean-up.
I think pstore tossing the oldest records above a (configurable) limit
(say, 32) per dump type makes sense...
--
Kees Cook
next prev parent reply other threads:[~2023-08-30 19:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 18:21 [GIT PULL] pstore updates for v6.6-rc1 Kees Cook
2023-08-28 20:15 ` pr-tracker-bot
2023-08-28 23:56 ` Linus Torvalds
2023-08-29 1:28 ` Kees Cook
2023-08-29 1:44 ` Linus Torvalds
2023-08-29 3:44 ` Kees Cook
2023-08-29 17:13 ` Linus Torvalds
2023-08-29 17:29 ` Ard Biesheuvel
2023-08-29 18:03 ` Linus Torvalds
2023-08-29 21:43 ` Ard Biesheuvel
2023-08-30 6:05 ` Eric Biggers
2023-08-30 7:48 ` Ard Biesheuvel
2023-08-30 17:00 ` Kees Cook [this message]
2023-08-30 9:10 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308300957.BCD878259@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=enlin.mu@unisoc.com \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=yunlong.xing@unisoc.com \
--cc=yuxiaozhang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox