From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A66C6FA8F for ; Wed, 30 Aug 2023 20:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240261AbjH3Upj (ORCPT ); Wed, 30 Aug 2023 16:45:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240634AbjH3UpX (ORCPT ); Wed, 30 Aug 2023 16:45:23 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67044E62 for ; Wed, 30 Aug 2023 13:43:42 -0700 (PDT) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E8D349E; Wed, 30 Aug 2023 22:40:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693428027; bh=9b1c7cdYA8/JOI7RsMAGYE8xBgsl/q6PNbhtx65ZuUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IRlFCMxuWblERy/He11C6Kb48XFen1mHEZ5qCECg6R3U2WrzA82MerHBS9N/4hH2D Je3b41An+HMnoMQGO/8TET1sTi0LlCxzkKX+0K9Ii/67dYGRGKw19t7/eI0Ld2hB+V Qt/H/B8PtMDHjBxqohkN3byOWx1g+UECXtcd1JSo= Date: Wed, 30 Aug 2023 23:41:59 +0300 From: Laurent Pinchart To: Biju Das Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , Jonas Karlman , Jernej Skrabec , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Douglas Anderson , Zhu Wang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v5 3/3] drm/bridge/analogix/anx78xx: Drop conditionals around of_node pointers Message-ID: <20230830204159.GA1928@pendragon.ideasonboard.com> References: <20230830170819.309269-1-biju.das.jz@bp.renesas.com> <20230830170819.309269-4-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230830170819.309269-4-biju.das.jz@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Biju, Thank you for the patch. On Wed, Aug 30, 2023 at 06:08:19PM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. How about doing this for all bridge drivers in one go ? > Suggested-by: Douglas Anderson > Signed-off-by: Biju Das > --- > v5: > * Split from patch#2 > --- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > index 6169db73d2fe..ad8241758896 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > @@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client *client) > > mutex_init(&anx78xx->lock); > > -#if IS_ENABLED(CONFIG_OF) > anx78xx->bridge.of_node = client->dev.of_node; > -#endif > > anx78xx->client = client; > i2c_set_clientdata(client, anx78xx); -- Regards, Laurent Pinchart