Re: [PATCH v1 1/1] zorro: Use helpers from ioport.h

Geert Uytterhoeven
2023-09-04T09:31:19Z

Hi Andy,

On Thu, Aug 31, 2023 at 2:16 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> We can use the DEFINE_RES_MEM_NAMED() macro and resource_contains() helper
> instead of reimplementing them in the code. No functional change intended.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for your patch!

> --- a/drivers/zorro/zorro.c
> +++ b/drivers/zorro/zorro.c
> @@ -117,17 +117,13 @@ static struct resource __init *zorro_find_parent_resource(
> int i;
>
> for (i = 0; i < bridge->num_resources; i++) {
> - struct resource *r = &bridge->resource[i];
> -
> - if (zorro_resource_start(z) >= r->start &&
> - zorro_resource_end(z) <= r->end)
> - return r;
> + if (resource_contains(&bridge->resource[i], &z->resource)

Missing closing parenthesis. What happened to your cross-compiler?

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v6.7 branch, with the above fixed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds