Re: [PATCH v1 1/1] zorro: Use helpers from ioport.h

Andy Shevchenko
2023-09-04T09:54:45Z

On Mon, Sep 04, 2023 at 11:31:03AM +0200, Geert Uytterhoeven wrote:
> Hi Andy,
>
> On Thu, Aug 31, 2023 at 2:16 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > We can use the DEFINE_RES_MEM_NAMED() macro and resource_contains() helper
> > instead of reimplementing them in the code. No functional change intended.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks for your patch!
>
> > --- a/drivers/zorro/zorro.c
> > +++ b/drivers/zorro/zorro.c
> > @@ -117,17 +117,13 @@ static struct resource __init *zorro_find_parent_resource(
> > int i;
> >
> > for (i = 0; i < bridge->num_resources; i++) {
> > - struct resource *r = &bridge->resource[i];
> > -
> > - if (zorro_resource_start(z) >= r->start &&
> > - zorro_resource_end(z) <= r->end)
> > - return r;
> > + if (resource_contains(&bridge->resource[i], &z->resource)
>
> Missing closing parenthesis. What happened to your cross-compiler?
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> i.e. will queue in the m68k for-v6.7 branch, with the above fixed.

I have usually three problems with it:
1) wrong branch to test;
2) no proper config is enabled;
3) other things due to my stupidity.

Choose one for this on your taste :-)

AFAIU you fixed that locally and applied (or going to). Thank you!
Otherwise tell me if I need to resend.