From: James Clark <james.clark@arm.com>
To: linux-perf-users@vger.kernel.org, irogers@google.com
Cc: James Clark <james.clark@arm.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Leo Yan <leo.yan@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Haixin Yu <yuhaixin.yhx@linux.alibaba.com>,
Kajol Jain <kjain@linux.ibm.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Yang Jihong <yangjihong1@huawei.com>,
Eduard Zingerman <eddyz87@gmail.com>,
Miguel Ojeda <ojeda@kernel.org>,
Liam Howlett <liam.howlett@oracle.com>,
Chen Zhongjin <chenzhongjin@huawei.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] perf test: Check result of has_event(cycles) test
Date: Thu, 31 Aug 2023 16:16:12 +0100 [thread overview]
Message-ID: <20230831151632.124985-2-james.clark@arm.com> (raw)
In-Reply-To: <20230831151632.124985-1-james.clark@arm.com>
Currently the function always returns 0, so even when the has_event()
test fails, the test still passes. Fix it by returning ret instead.
Signed-off-by: James Clark <james.clark@arm.com>
---
tools/perf/tests/expr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/expr.c b/tools/perf/tests/expr.c
index 81229fa4f1e9..39be7f3b3a53 100644
--- a/tools/perf/tests/expr.c
+++ b/tools/perf/tests/expr.c
@@ -263,7 +263,7 @@ static int test__expr(struct test_suite *t __maybe_unused, int subtest __maybe_u
expr__ctx_free(ctx);
- return 0;
+ return ret;
}
DEFINE_SUITE("Simple expression parser", expr);
--
2.34.1
next prev parent reply other threads:[~2023-08-31 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 15:16 [PATCH 0/7] perf: strcmp_cpuid_str() expression fixups James Clark
2023-08-31 15:16 ` James Clark [this message]
2023-08-31 15:16 ` [PATCH 2/7] perf jevents: Remove unused keyword James Clark
2023-08-31 15:16 ` [PATCH 3/7] perf util: Add a function for replacing characters in a string James Clark
2023-09-02 2:48 ` Ian Rogers
2023-08-31 15:16 ` [PATCH 4/7] perf test: Add a test for strcmp_cpuid_str() expression James Clark
2023-08-31 15:16 ` [PATCH 5/7] perf pmu: Move pmu__find_core_pmu() to pmus.c James Clark
2023-09-12 19:26 ` Arnaldo Carvalho de Melo
2023-09-13 10:20 ` James Clark
2023-09-13 10:32 ` James Clark
2023-09-13 15:37 ` James Clark
2023-08-31 15:16 ` [PATCH 6/7] perf pmus: Simplify perf_pmus__find_core_pmu() James Clark
2023-08-31 15:16 ` [PATCH 7/7] perf pmu: Remove unused function James Clark
2023-09-02 2:53 ` [PATCH 0/7] perf: strcmp_cpuid_str() expression fixups Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831151632.124985-2-james.clark@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=chenzhongjin@huawei.com \
--cc=eddyz87@gmail.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=liam.howlett@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=will@kernel.org \
--cc=yangjihong1@huawei.com \
--cc=yuhaixin.yhx@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox