From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 797E2C83F01 for ; Thu, 31 Aug 2023 14:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346425AbjHaOVz (ORCPT ); Thu, 31 Aug 2023 10:21:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346435AbjHaOVs (ORCPT ); Thu, 31 Aug 2023 10:21:48 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7045DE79 for ; Thu, 31 Aug 2023 07:21:38 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 698991BF212; Thu, 31 Aug 2023 14:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1693491696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aByMOVFmM+SkUtrpBTr+ttq0hQzvoU/QCipPW40qS2o=; b=nvJAln9SgXRKA5Lz+jYUK/tvyRDj8d4nXwORPilNm7f2P56SAK0bEnDKXouUpvtK+wX6XX GwapBu/sS6LpjH0UHlteMJUFELqVM20JGwx01yuxCCsENH5lMe1QKZd7JX7GOAk0Qw/0DI Pj06mWEPK3PZDRC5TMcUZyzBhcUTZw1XVIhmKIwbVm361RxvBHsgloX74JjeidFd5Zg0pL HFPdJf6X50CAaHfYDEa8yGSZmCC5D6wOPKshWtlLcLGipYYSJS0Pa+USRDpOxDlddTQs1/ QXWYHZP/rWv88h82GM3/o6jKZJKjjiQ4cw7zwfif3PDlFSUhelUA45fi+7Gx7A== Date: Thu, 31 Aug 2023 16:21:34 +0200 From: Miquel Raynal To: Frank Li Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] i3c: master: svc: fix probe failure when no i3c device exist Message-ID: <20230831162134.6ccbaf23@xps-13> In-Reply-To: <20230831141324.2841525-1-Frank.Li@nxp.com> References: <20230831141324.2841525-1-Frank.Li@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frank, Frank.Li@nxp.com wrote on Thu, 31 Aug 2023 10:13:24 -0400: > I3C masters are expected to support hot-join. This means at initialization > time we might not yet discover any device and this should not be treated > as a fatal error. >=20 > During the DAA procedure which happens at probe time, if no device has > joined, all CCC will be NACKed (from a bus perspective). This leads to an > early return with an error code which fails the probe of the master. >=20 > Let's avoid this by just telling the core through an I3C_ERROR_M2 > return command code that no device was discovered, which is a valid > situation. This way the master will no longer bail out and fail to probe > for a wrong reason. >=20 > Cc: stable@vger.kernel.org > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") > Signed-off-by: Frank Li Acked-by: Miquel Raynal Thanks, Miqu=C3=A8l