The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Wenchao Hao <haowenchao2@huawei.com>
To: "James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	<linux-scsi@vger.kernel.org>
Cc: Hannes Reinecke <hare@suse.de>, <linux-kernel@vger.kernel.org>,
	<louhongxiang@huawei.com>, <lixiaokeng@huawei.com>,
	Wenchao Hao <haowenchao2@huawei.com>
Subject: [RFC PATCH v2 02/19] scsi: scsi_error: Move complete variable eh_action from shost to sdevice
Date: Fri, 1 Sep 2023 17:41:10 +0800	[thread overview]
Message-ID: <20230901094127.2010873-3-haowenchao2@huawei.com> (raw)
In-Reply-To: <20230901094127.2010873-1-haowenchao2@huawei.com>

eh_action is used to wait for error handle command's completion if scsi
command is send in error handle. Now the error handler might based on
scsi_device, so move it to scsi_device.

This is preparation for a genernal LUN/target based error handle
strategy.

Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
---
 drivers/scsi/scsi_error.c  | 6 +++---
 include/scsi/scsi_device.h | 2 ++
 include/scsi/scsi_host.h   | 2 --
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 1d1d97b94613..879fdd7c165b 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -914,7 +914,7 @@ void scsi_eh_done(struct scsi_cmnd *scmd)
 	SCSI_LOG_ERROR_RECOVERY(3, scmd_printk(KERN_INFO, scmd,
 			"%s result: %x\n", __func__, scmd->result));
 
-	eh_action = scmd->device->host->eh_action;
+	eh_action = scmd->device->eh_action;
 	if (eh_action)
 		complete(eh_action);
 }
@@ -1203,7 +1203,7 @@ static enum scsi_disposition scsi_send_eh_cmnd(struct scsi_cmnd *scmd,
 
 retry:
 	scsi_eh_prep_cmnd(scmd, &ses, cmnd, cmnd_size, sense_bytes);
-	shost->eh_action = &done;
+	sdev->eh_action = &done;
 
 	scsi_log_send(scmd);
 	scmd->submitter = SUBMITTED_BY_SCSI_ERROR_HANDLER;
@@ -1246,7 +1246,7 @@ static enum scsi_disposition scsi_send_eh_cmnd(struct scsi_cmnd *scmd,
 		rtn = SUCCESS;
 	}
 
-	shost->eh_action = NULL;
+	sdev->eh_action = NULL;
 
 	scsi_log_completion(scmd, rtn);
 
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 08ed9a03015d..df3f1b8d1390 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -324,6 +324,8 @@ struct scsi_device {
 	enum scsi_device_state sdev_state;
 	struct task_struct	*quiesced_by;
 	struct scsi_device_eh	*eh;
+	struct completion	*eh_action;	/* Wait for specific actions */
+						/* on the device. */
 	unsigned long		sdev_data[];
 } __attribute__((aligned(sizeof(unsigned long))));
 
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 70b7475dcf56..def0d99e9b36 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -554,8 +554,6 @@ struct Scsi_Host {
 	struct list_head	eh_abort_list;
 	struct list_head	eh_cmd_q;
 	struct task_struct    * ehandler;  /* Error recovery thread. */
-	struct completion     * eh_action; /* Wait for specific actions on the
-					      host. */
 	wait_queue_head_t       host_wait;
 	const struct scsi_host_template *hostt;
 	struct scsi_transport_template *transportt;
-- 
2.35.3


  parent reply	other threads:[~2023-09-01  9:42 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01  9:41 [RFC PATCH v2 00/18] scsi: scsi_error: Introduce new error handle mechanism Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 01/19] scsi: scsi_error: Define framework for LUN/target based error handle Wenchao Hao
2023-09-01  9:41 ` Wenchao Hao [this message]
2023-09-01  9:41 ` [RFC PATCH v2 03/19] scsi: scsi_error: Check if to do reset in scsi_try_xxx_reset Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 04/19] scsi: scsi_error: Add helper scsi_eh_sdev_stu to do START_UNIT Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 05/19] scsi: scsi_error: Add helper scsi_eh_sdev_reset to do lun reset Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 06/19] scsi: scsi_error: Add flags to mark error handle steps has done Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 07/19] scsi: scsi_error: Add helper to handle scsi device's error command list Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 08/19] scsi: scsi_error: Add a general LUN based error handler Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 09/19] scsi: core: increase/decrease target_busy without check can_queue Wenchao Hao
2023-09-05 23:55   ` Mike Christie
2023-09-06 12:12     ` Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 10/19] scsi: scsi_error: Add helper to handle scsi target's error command list Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 11/19] scsi: scsi_error: Add a general target based error handler Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 12/19] scsi: scsi_debug: Add param to control LUN bassed " Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 13/19] scsi: scsi_debug: Add param to control target based error handle Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 14/19] scsi: mpt3sas: Add param to control LUN " Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 15/19] scsi: mpt3sas: Add param to control target " Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 16/19] scsi: smartpqi: Add param to control LUN " Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 17/19] scsi: megaraid_sas: Add param to control target " Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 18/19] scsi: virtio_scsi: Add param to control LUN " Wenchao Hao
2023-09-01  9:41 ` [RFC PATCH v2 19/19] scsi: iscsi_tcp: " Wenchao Hao
2023-09-05  1:32 ` [RFC PATCH v2 00/18] scsi: scsi_error: Introduce new error handle mechanism haowenchao (C)
2023-09-06  0:22 ` Mike Christie
2023-09-06 11:15   ` haowenchao (C)
2023-09-06 15:56     ` Mike Christie
2023-09-07 12:38       ` Wenchao Hao
2023-09-14  6:20 ` Wenchao Hao
2023-09-25 16:52   ` Mike Christie
2023-09-25 14:55 ` Christoph Hellwig
2023-09-25 15:07   ` Wenchao Hao
2023-09-25 17:54     ` Mike Christie
2023-09-26  7:26       ` Christoph Hellwig
2023-09-27  6:26         ` Hannes Reinecke
2023-09-26 12:57       ` Wenchao Hao
2023-09-26 17:37         ` Mike Christie
2023-09-27  9:39           ` Wenchao Hao
2023-09-27  7:59         ` Hannes Reinecke
2023-09-27  9:41           ` Wenchao Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230901094127.2010873-3-haowenchao2@huawei.com \
    --to=haowenchao2@huawei.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lixiaokeng@huawei.com \
    --cc=louhongxiang@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox