From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C44C001DB for ; Sat, 2 Sep 2023 11:02:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352011AbjIBLC1 (ORCPT ); Sat, 2 Sep 2023 07:02:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232958AbjIBLC0 (ORCPT ); Sat, 2 Sep 2023 07:02:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEE4112D for ; Sat, 2 Sep 2023 04:02:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8C0AFB826E6 for ; Sat, 2 Sep 2023 11:02:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33C0FC433C7; Sat, 2 Sep 2023 11:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693652541; bh=nWRp3kNt0uCKDvR/efj7kKP5j/V5vGO+TJUPxq8elAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UrjcyFPTU160rKO1Kt5+wuQbuw/7eRXtQtTi7/Swk7y6ewBq3wg0e0oStgpLsusQQ zV/xmjisEPfLduUTVDQJ0W+n1JByouskEBEJDNX9dPdp1Poaizxr/P5KwUrTs2tiTa f14Lgt4db+SU6JE3Z/m37wBPJX0H+Ni5UAV+ygFzNUVtpf5hpsb4OqrR2FoFGAC42R 5m5ATCxAsj54sobWtYs1nV7a/9p4smXKDq+absVI7AXIWxtcbA5LwKHYq1onnCybfS g5rSLhmJoeWdhFkuwQhl9+NOXXSkno6+TUTcBeb6yM4uHsZBTdz+GKuwTiTSKG22xv COIjyYMxH2Mzg== Date: Sat, 2 Sep 2023 12:02:16 +0100 From: Conor Dooley To: Prabhakar Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Geert Uytterhoeven , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Lad Prabhakar , kernel test robot Subject: Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config Message-ID: <20230902-plexiglas-cannot-e4ca8494ef95@spud> References: <20230901110320.312674-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZRn/ZXZBHlvjdjg5" Content-Disposition: inline In-Reply-To: <20230901110320.312674-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZRn/ZXZBHlvjdjg5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 01, 2023 at 12:03:20PM +0100, Prabhakar wrote: > From: Lad Prabhakar >=20 > Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is > enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to > avoid any build failures. >=20 > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@i= ntel.com/ > Signed-off-by: Lad Prabhakar Replied here earlier, but pressed the wrong key & it only went to the list. I think this patch probably also needs to grow a Fixes tag, for commit f2863f30d1b0 ("riscv: errata: Add Andes alternative ports"). The 4 Kconfig patches ideally would've been in a series, since 3 of the 4 seem to be fixes & the 4th depends on one of the fixes being applied. Thaks, Conor. > --- > arch/riscv/Kconfig.errata | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata > index bee5d838763b..566bcefeab50 100644 > --- a/arch/riscv/Kconfig.errata > +++ b/arch/riscv/Kconfig.errata > @@ -2,7 +2,7 @@ menu "CPU errata selection" > =20 > config ERRATA_ANDES > bool "Andes AX45MP errata" > - depends on RISCV_ALTERNATIVE > + depends on RISCV_ALTERNATIVE && RISCV_SBI > help > All Andes errata Kconfig depend on this Kconfig. Disabling > this Kconfig will disable all Andes errata. Please say "Y" > --=20 > 2.34.1 >=20 >=20 > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv --ZRn/ZXZBHlvjdjg5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZPMWOAAKCRB4tDGHoIJi 0taDAQCl8QFGGuuCZWZwjq0NAg/MOvQ1IE3aTOyReSkf3CSWmgEAhGTMm/mRzXsS Y5+ZrqbMvP+CtswbvJi7NfMs8BhfPgw= =KonS -----END PGP SIGNATURE----- --ZRn/ZXZBHlvjdjg5--