From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE99EC83F2D for ; Sun, 3 Sep 2023 14:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240991AbjICOni (ORCPT ); Sun, 3 Sep 2023 10:43:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbjICOnh (ORCPT ); Sun, 3 Sep 2023 10:43:37 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8D16F5 for ; Sun, 3 Sep 2023 07:43:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 03E6FCE0A05 for ; Sun, 3 Sep 2023 14:43:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6B85C433C7; Sun, 3 Sep 2023 14:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1693752209; bh=ttlE3ok8BQbOnf1ACAmLjfWl3fHYfC2CoxqqsrbpSQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lL1tLxJM/3DAbT9CjlVRgdjhJ9SnlCFEcJRKougTIVGembhYtWExp62H31GJLmwPC zf2gi2DcflUkjKA5a1FP+hIrVL3GRM+NsOczdSyQIgpfwt1BKmiJCSPwOre1lKvu4X UXiFFhsuDDMXFVKiOHfxGoEy4Xfivw6nAemM0Nn4= Date: Sun, 3 Sep 2023 16:43:15 +0200 From: Greg KH To: Jonathan Bergh Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vme_user: Add missing '*' in multiline comments Message-ID: <2023090301-emission-scarce-8272@gregkh> References: <20230903140617.567850-1-bergh.jonathan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230903140617.567850-1-bergh.jonathan@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 03, 2023 at 04:06:17PM +0200, Jonathan Bergh wrote: > This patch resolves a warning reported by checkpatch where multiline > block comments should use '*' on intermediate lines in order to adhere > to the Linux kernel coding-style guidelines. > > Signed-off-by: Jonathan Bergh > --- > drivers/staging/vme_user/vme_fake.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c > index 7c53a8a7b79b..90aaf650524d 100644 > --- a/drivers/staging/vme_user/vme_fake.c > +++ b/drivers/staging/vme_user/vme_fake.c > @@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size, > { > kfree(vaddr); > /* > - dma_free_coherent(parent, size, vaddr, dma); > -*/ > + * dma_free_coherent(parent, size, vaddr, dma); > + */ As this code isn't being used, why not just delete it instead? thanks, greg k-h