public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: John Ogness <john.ogness@linutronix.de>, Petr Mladek <pmladek@suse.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH printk v3 2/7] printk: nbcon: Add acquire/release logic
Date: Mon, 4 Sep 2023 00:43:20 +0800	[thread overview]
Message-ID: <202309040026.yyn4RCk1-lkp@intel.com> (raw)
In-Reply-To: <20230903150539.245076-3-john.ogness@linutronix.de>

Hi John,

kernel test robot noticed the following build warnings:

[auto build test WARNING on cb65d08d735e00cc55ad7700a82a453bb88c93a3]

url:    https://github.com/intel-lab-lkp/linux/commits/John-Ogness/printk-Add-non-BKL-nbcon-console-basic-infrastructure/20230903-230708
base:   cb65d08d735e00cc55ad7700a82a453bb88c93a3
patch link:    https://lore.kernel.org/r/20230903150539.245076-3-john.ogness%40linutronix.de
patch subject: [PATCH printk v3 2/7] printk: nbcon: Add acquire/release logic
config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20230904/202309040026.yyn4RCk1-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230904/202309040026.yyn4RCk1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309040026.yyn4RCk1-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/printk/nbcon.c:392: warning: expecting prototype for nbcon_context_try_acquire_hostile(). Prototype was for nbcon_context_acquire_hostile() instead


vim +392 kernel/printk/nbcon.c

   379	
   380	/**
   381	 * nbcon_context_try_acquire_hostile - Acquire via unsafe hostile takeover
   382	 * @ctxt:	The context of the caller
   383	 * @cur:	The current console state
   384	 *
   385	 * @cur is updated to the new console state.
   386	 *
   387	 * The general procedure is to set @prio (forcing ownership). This method
   388	 * must only be used as a final attempt during panic.
   389	 */
   390	static void nbcon_context_acquire_hostile(struct nbcon_context *ctxt,
   391						  struct nbcon_state *cur)
 > 392	{
   393		unsigned int cpu = smp_processor_id();
   394		struct console *con = ctxt->console;
   395		struct nbcon_state new;
   396	
   397		do {
   398			new.atom = cur->atom;
   399			new.cpu			= cpu;
   400			new.prio		= ctxt->prio;
   401			new.unsafe		|= cur->unsafe_takeover;
   402			new.unsafe_takeover	|= cur->unsafe;
   403	
   404		} while (!nbcon_state_try_cmpxchg(con, cur, &new));
   405	
   406		cur->atom = new.atom;
   407	}
   408	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2023-09-03 16:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-03 15:05 [PATCH printk v3 0/7] provide nbcon base John Ogness
2023-09-03 15:05 ` [PATCH printk v3 1/7] printk: Add non-BKL (nbcon) console basic infrastructure John Ogness
2023-09-05 11:45   ` Petr Mladek
2023-09-03 15:05 ` [PATCH printk v3 2/7] printk: nbcon: Add acquire/release logic John Ogness
2023-09-03 16:32   ` kernel test robot
2023-09-05  9:07     ` John Ogness
2023-09-03 16:43   ` kernel test robot [this message]
2023-09-06 13:01   ` Petr Mladek
2023-09-03 15:05 ` [PATCH printk v3 3/7] printk: nbcon: Add buffer management John Ogness
2023-09-06 13:26   ` Petr Mladek
2023-09-08 13:03     ` John Ogness
2023-09-03 15:05 ` [PATCH printk v3 4/7] printk: nbcon: Add ownership state functions John Ogness
2023-09-06 13:57   ` Petr Mladek
2023-09-08 13:20     ` John Ogness
2023-09-03 15:05 ` [PATCH printk v3 5/7] printk: nbcon: Add sequence handling John Ogness
2023-09-07  7:45   ` Petr Mladek
2023-09-03 15:05 ` [PATCH printk v3 6/7] printk: nbcon: Add emit function and callback function for atomic printing John Ogness
2023-09-07  8:22   ` Petr Mladek
2023-09-03 15:05 ` [PATCH printk v3 7/7] printk: nbcon: Add functions for drivers to mark unsafe regions John Ogness
2023-09-07  8:24   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202309040026.yyn4RCk1-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox