public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Ze Zuo <zuoze1@huawei.com>
Cc: minchan@kernel.org, senozhatsky@chromium.org, axboe@kernel.dk,
	akpm@linux-foundation.org, ying.huang@intel.com,
	aneesh.kumar@linux.ibm.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	wangkefeng.wang@huawei.com
Subject: Re: [PATCH 1/2] zram: add a parameter "node_id" for zram
Date: Tue, 5 Sep 2023 14:01:57 +0900	[thread overview]
Message-ID: <20230905050157.GD610023@google.com> (raw)
In-Reply-To: <20230901071942.207010-2-zuoze1@huawei.com>

On (23/09/01 15:19), Ze Zuo wrote:
> Now, zram memory allocation is random, however in some cases, specifying
> specific nodes for memory allocation for zram may have good effects.

I'm sorry, but that needs benchmarks in order to be justified.

> In addition, when memory tier is supported, demotion can be achieved not
> only through page migration,  it is also possible to apply for memory by
> specifying zram on low-speed device nodes, such as CXL memory devices,
> and compressing pages to these devices through memory reclamation to
> achieve similar effects to migration.

zram->table has nothing to do with zsmalloc pool. zram->table is a
fixed size (it depends on block device size) array that maps block
index to zsmalloc handle. It's allocated once, when the device is
initialized. Compressed pages are not stored there, zsmalloc pool
is a separate thing.

[..]

> +	zram->table = vzalloc_node(array_size(num_pages, sizeof(*zram->table)), node_id);

  parent reply	other threads:[~2023-09-05 16:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01  7:19 [PATCH 0/2] zram: support for specific numa node for zram Ze Zuo
2023-09-01  7:19 ` [PATCH 1/2] zram: add a parameter "node_id" " Ze Zuo
2023-09-02 22:55   ` Andrew Morton
2023-09-05  5:01   ` Sergey Senozhatsky [this message]
2023-09-01  7:19 ` [PATCH 2/2] zram: take the benefit of kvzalloc_node Ze Zuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230905050157.GD610023@google.com \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=ying.huang@intel.com \
    --cc=zuoze1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox