From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
Jason Gunthorpe <jgg@ziepe.ca>,
James Smart <james.smart@broadcom.com>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [RFC v1 1/4] nvmet-trace: avoid dereferencing pointer too early
Date: Tue, 5 Sep 2023 10:33:08 +0200 [thread overview]
Message-ID: <20230905083308.GA20920@lst.de> (raw)
In-Reply-To: <77nt3zr7rap6w7bpvm6vfdqqf4xc46afq4tzlifsn3zlry5wvh@t2e6orslw6on>
On Tue, Sep 05, 2023 at 10:24:51AM +0200, Daniel Wagner wrote:
> On Tue, Sep 05, 2023 at 08:48:46AM +0200, Christoph Hellwig wrote:
> > > +static inline u16 nvmet_req_to_ctrl_id(struct nvmet_req *req)
> > > {
> > > - return req->sq->ctrl;
> > > + if (!req->sq || !req->sq->ctrl)
> > > + return 0;
> > > + return req->sq->ctrl->cntlid;
> >
> > Can you add a comment here why we have this check?
>
> /*
> * The queue and controller pointer are not valid until an
> * association has been established.
> */
sounds good.
next prev parent reply other threads:[~2023-09-05 16:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 9:13 [RFC v1 0/4] nvmet-fc blktests & autoconnect fixes Daniel Wagner
2023-08-29 9:13 ` [RFC v1 1/4] nvmet-trace: avoid dereferencing pointer too early Daniel Wagner
2023-09-05 6:48 ` Christoph Hellwig
2023-09-05 8:24 ` Daniel Wagner
2023-09-05 8:33 ` Christoph Hellwig [this message]
2023-09-06 11:00 ` Hannes Reinecke
2023-08-29 9:13 ` [RFC v1 2/4] nvmet-trace: null terminate device name string correctly Daniel Wagner
2023-09-05 6:49 ` Christoph Hellwig
2023-09-05 10:25 ` Daniel Wagner
2023-09-06 11:01 ` Hannes Reinecke
2023-08-29 9:13 ` [RFC v1 3/4] nvmet-fc: untangle cross refcounting objects Daniel Wagner
2023-09-06 11:22 ` Hannes Reinecke
2023-09-11 10:08 ` Daniel Wagner
2023-08-29 9:13 ` [RFC v1 4/4] nvmet-discovery: do not use invalid port Daniel Wagner
2023-09-05 6:50 ` Christoph Hellwig
2023-09-05 10:40 ` Daniel Wagner
2023-09-11 14:44 ` Daniel Wagner
2023-09-11 18:19 ` Daniel Wagner
2023-09-12 6:38 ` Daniel Wagner
2023-09-13 11:35 ` Christoph Hellwig
2023-09-13 11:59 ` Daniel Wagner
2023-09-06 11:23 ` Hannes Reinecke
2023-08-29 9:13 ` [RFC v1 4/4] nvmet-discovery: Do " Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905083308.GA20920@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox