From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE2ECCA0FFE for ; Tue, 5 Sep 2023 16:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347398AbjIEQRv (ORCPT ); Tue, 5 Sep 2023 12:17:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353990AbjIEJCu (ORCPT ); Tue, 5 Sep 2023 05:02:50 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6538FBF; Tue, 5 Sep 2023 02:02:47 -0700 (PDT) Received: from pendragon.ideasonboard.com (ftip006315900.acc1.colindale.21cn-nte.bt.net [81.134.214.249]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CDDE128D; Tue, 5 Sep 2023 11:01:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693904479; bh=i5xgoAvknUQnAeBrZlobtbTH4p/BfgvRHjqgFdrRzAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mOHafGtT3Q36EEF7HniHebrGl8NFSP2+8LDoiWnYIVMmqAIhnixtIXnLXR5cQc8ut 1w+tfxF0njauRH3r2BNE5GvHe3n0pybRvFN97mj1wlB85q1LqHnnq8qPXNIOePtBzS NN64tVqdxLSHqtJbpHR0azVqWOTCO2azMVlmxZVQ= Date: Tue, 5 Sep 2023 12:02:58 +0300 From: Laurent Pinchart To: Alain Volmat Cc: Hugues Fruchet , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Sakari Ailus , Dan Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] ARM: dts: stm32: add dcmipp support to stm32mp135 Message-ID: <20230905090258.GC31594@pendragon.ideasonboard.com> References: <20230901155732.252436-1-alain.volmat@foss.st.com> <20230901155732.252436-5-alain.volmat@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230901155732.252436-5-alain.volmat@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alain, Thank you for the patch. On Fri, Sep 01, 2023 at 05:57:23PM +0200, Alain Volmat wrote: > From: Hugues Fruchet > > Add dcmipp support to STM32MP135. > > Signed-off-by: Hugues Fruchet > Signed-off-by: Alain Volmat > --- > arch/arm/boot/dts/st/stm32mp135.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/st/stm32mp135.dtsi b/arch/arm/boot/dts/st/stm32mp135.dtsi > index abf2acd37b4e..beee9ec7ed0d 100644 > --- a/arch/arm/boot/dts/st/stm32mp135.dtsi > +++ b/arch/arm/boot/dts/st/stm32mp135.dtsi > @@ -8,5 +8,13 @@ > > / { > soc { > + dcmipp: dcmipp@5a000000 { > + compatible = "st,stm32mp13-dcmipp"; > + reg = <0x5a000000 0x400>; > + interrupts = ; > + resets = <&rcc DCMIPP_R>; > + clocks = <&rcc DCMIPP_K>; > + status = "disabled"; This needs a port, as it's marked as required in the bindings. You can leave the endpoint out. With this fixed, Reviewed-by: Laurent Pinchart > + }; > }; > }; -- Regards, Laurent Pinchart