Re: [PATCH v3 4/5] ARM: dts: stm32: add dcmipp support to stm32mp135

Alain Volmat
2023-09-22T16:03:18Z

Hi Laurent,

On Tue, Sep 05, 2023 at 12:02:58PM +0300, Laurent Pinchart wrote:
> Hi Alain,
>
> Thank you for the patch.
>
> On Fri, Sep 01, 2023 at 05:57:23PM +0200, Alain Volmat wrote:
> > From: Hugues Fruchet <hugues.fruchet@foss.st.com>
> >
> > Add dcmipp support to STM32MP135.
> >
> > Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
> > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> > ---
> > arch/arm/boot/dts/st/stm32mp135.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32mp135.dtsi b/arch/arm/boot/dts/st/stm32mp135.dtsi
> > index abf2acd37b4e..beee9ec7ed0d 100644
> > --- a/arch/arm/boot/dts/st/stm32mp135.dtsi
> > +++ b/arch/arm/boot/dts/st/stm32mp135.dtsi
> > @@ -8,5 +8,13 @@
> >
> > / {
> > soc {
> > + dcmipp: dcmipp@5a000000 {
> > + compatible = "st,stm32mp13-dcmipp";
> > + reg = <0x5a000000 0x400>;
> > + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> > + resets = <&rcc DCMIPP_R>;
> > + clocks = <&rcc DCMIPP_K>;
> > + status = "disabled";
>
> This needs a port, as it's marked as required in the bindings. You can
> leave the endpoint out.

I first agreed with your comment but, having done the check (make
CHECK_DTBS=y ...) this doesn't seem to be required because the dcmipp
node is kept disabled within our dtsi.
(it is later on only enabled in dts file which as well have the port
property).
Indeed, to check this I changed it to okay and DTC_CHK complained about
missing port property.

Hence, I'd think that port doesn't have to be added in this dtsi file.
Would you agree with that ?

Regards,
Alain

>
> With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > + };
> > };
> > };
>
> --
> Regards,
>
> Laurent Pinchart