From: kernel test robot <lkp@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Josef Bacik <josef@toxicpanda.com>
Subject: block/disk-events.c:302: warning: Excess function parameter 'events' description in 'disk_force_media_change'
Date: Wed, 6 Sep 2023 10:08:21 +0800 [thread overview]
Message-ID: <202309060957.vfl0mUur-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 65d6e954e37872fd9afb5ef3fc0481bb3c2f20f4
commit: ab6860f62bfe329e11e5b5b7295b673c9c3a62d0 block: simplify the disk_force_media_change interface
date: 2 weeks ago
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20230906/202309060957.vfl0mUur-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230906/202309060957.vfl0mUur-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309060957.vfl0mUur-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> block/disk-events.c:302: warning: Excess function parameter 'events' description in 'disk_force_media_change'
vim +302 block/disk-events.c
d5870edfa3afc46 Christoph Hellwig 2021-06-24 291
e6138dc12de9df1 Matteo Croce 2021-07-13 292 /**
e6138dc12de9df1 Matteo Croce 2021-07-13 293 * disk_force_media_change - force a media change event
e6138dc12de9df1 Matteo Croce 2021-07-13 294 * @disk: the disk which will raise the event
e6138dc12de9df1 Matteo Croce 2021-07-13 295 * @events: the events to raise
e6138dc12de9df1 Matteo Croce 2021-07-13 296 *
ab6860f62bfe329 Christoph Hellwig 2023-08-11 297 * Should be called when the media changes for @disk. Generates a uevent
ab6860f62bfe329 Christoph Hellwig 2023-08-11 298 * and attempts to free all dentries and inodes and invalidates all block
e6138dc12de9df1 Matteo Croce 2021-07-13 299 * device page cache entries in that case.
e6138dc12de9df1 Matteo Croce 2021-07-13 300 */
ab6860f62bfe329 Christoph Hellwig 2023-08-11 301 void disk_force_media_change(struct gendisk *disk)
e6138dc12de9df1 Matteo Croce 2021-07-13 @302 {
ab6860f62bfe329 Christoph Hellwig 2023-08-11 303 disk_event_uevent(disk, DISK_EVENT_MEDIA_CHANGE);
b90ecc0379eb7bb Demi Marie Obenour 2023-06-07 304 inc_diskseq(disk);
e6138dc12de9df1 Matteo Croce 2021-07-13 305 if (__invalidate_device(disk->part0, true))
e6138dc12de9df1 Matteo Croce 2021-07-13 306 pr_warn("VFS: busy inodes on changed media %s\n",
e6138dc12de9df1 Matteo Croce 2021-07-13 307 disk->disk_name);
e6138dc12de9df1 Matteo Croce 2021-07-13 308 set_bit(GD_NEED_PART_SCAN, &disk->state);
e6138dc12de9df1 Matteo Croce 2021-07-13 309 }
e6138dc12de9df1 Matteo Croce 2021-07-13 310 EXPORT_SYMBOL_GPL(disk_force_media_change);
e6138dc12de9df1 Matteo Croce 2021-07-13 311
:::::: The code at line 302 was first introduced by commit
:::::: e6138dc12de9df17cbda9c40314d69592855ac5e block: add a helper to raise a media changed event
:::::: TO: Matteo Croce <mcroce@microsoft.com>
:::::: CC: Jens Axboe <axboe@kernel.dk>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-09-06 2:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309060957.vfl0mUur-lkp@intel.com \
--to=lkp@intel.com \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox