[PATCH] firewire: allow deactivating the IEEE1394 menuconfig section at once

[PATCH] firewire: allow deactivating the IEEE1394 menuconfig section at once

[Jan Engelhardt]

Presently, one needs to enter "FireWire (IEEE 1394) subsystem --->",
then deselect all options individually. Speed up that process by
making the "--->" line be togglable in its own right.

Signed-off-by: Jan Engelhardt <jengelh@inai.de>
---
 drivers/firewire/Kconfig | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
index 0a6596b027db..be1a9e685782 100644
--- a/drivers/firewire/Kconfig
+++ b/drivers/firewire/Kconfig
@@ -1,8 +1,18 @@
 # SPDX-License-Identifier: GPL-2.0-only
-menu "IEEE 1394 (FireWire) support"
+menuconfig FIREWIRE_SUPPORT
+	bool "IEEE 1394 (FireWire) support"
+	default y
 	depends on PCI || COMPILE_TEST
 	# firewire-core does not depend on PCI but is
 	# not useful without PCI controller driver
+	help
+	  Support for FireWire.
+
+	  The answer to this question will not directly affect the
+	  kernel: saying N will just cause the configurator to skip all
+	  the questions about FireWire.
+
+if FIREWIRE_SUPPORT
 
 config FIREWIRE
 	tristate "FireWire driver stack"
@@ -96,4 +106,4 @@ config FIREWIRE_NOSY
 
 	  If unsure, say N.
 
-endmenu
+endif # FIREWIRE_SUPPORT
-- 
2.42.0

Re: [PATCH] firewire: allow deactivating the IEEE1394 menuconfig section at once

[Takashi Sakamoto]

Hi,

On Wed, Sep 06, 2023 at 10:12:16AM +0200, Jan Engelhardt wrote:
> Presently, one needs to enter "FireWire (IEEE 1394) subsystem --->",
> then deselect all options individually. Speed up that process by
> making the "--->" line be togglable in its own right.
> 
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
>  drivers/firewire/Kconfig | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)

We are at the second half of merge window for v6.6 kernel, while the patch
looks good to me. I applied it to for-next branch and will send it to Linus
within a few days, after it passes check by for-next integration.

> diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
> index 0a6596b027db..be1a9e685782 100644
> --- a/drivers/firewire/Kconfig
> +++ b/drivers/firewire/Kconfig
> @@ -1,8 +1,18 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> -menu "IEEE 1394 (FireWire) support"
> +menuconfig FIREWIRE_SUPPORT
> +	bool "IEEE 1394 (FireWire) support"
> +	default y
>  	depends on PCI || COMPILE_TEST
>  	# firewire-core does not depend on PCI but is
>  	# not useful without PCI controller driver
> +	help
> +	  Support for FireWire.
> +
> +	  The answer to this question will not directly affect the
> +	  kernel: saying N will just cause the configurator to skip all
> +	  the questions about FireWire.
> +
> +if FIREWIRE_SUPPORT
>  
>  config FIREWIRE
>  	tristate "FireWire driver stack"
> @@ -96,4 +106,4 @@ config FIREWIRE_NOSY
>  
>  	  If unsure, say N.
>  
> -endmenu
> +endif # FIREWIRE_SUPPORT
> -- 
> 2.42.0


Thanks

Takashi Sakamoto