From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08AB9EC873A for ; Thu, 7 Sep 2023 15:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231578AbjIGPhY (ORCPT ); Thu, 7 Sep 2023 11:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344756AbjIGPdp (ORCPT ); Thu, 7 Sep 2023 11:33:45 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5623CE49; Thu, 7 Sep 2023 08:33:21 -0700 (PDT) Received: from pendragon.ideasonboard.com (ftip006315900.acc1.colindale.21cn-nte.bt.net [81.134.214.249]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DC01831B9; Thu, 7 Sep 2023 17:03:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1694098987; bh=Tu+mxxpH015oWyJsbCEuUxhFMyaqhb+/X6gaqeEsbwg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oOvU/38KLai0fMlQ+LtyaAWZAT/ZTbDaShtN+HYmdnM9UJCAherctnVcG4dY+shSf 5lfCWRyXTOMkthsUqE8/QPfwwyv596Xv6zntZ/ErZ8QcHM3p7c/wTFeaOZq4DkL+c3 iHzUolfCJeNpZcM4HSKBw56qOH0sYULK5VmhSPHE= Date: Thu, 7 Sep 2023 18:04:48 +0300 From: Laurent Pinchart To: Paul Elder Cc: Kieran Bingham , Krzysztof Kozlowski , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 3/3] arm64: dts: mediatek: mt8365-pumpkin: Add overlays for thp7312 cameras Message-ID: <20230907150448.GD17610@pendragon.ideasonboard.com> References: <502fc7b1-a32d-6901-3a45-d2aa0e0c3849@linaro.org> <20230906083237.GL7971@pendragon.ideasonboard.com> <20230906090058.GB17308@pendragon.ideasonboard.com> <59e07c6a-6f1b-0cc7-dddc-96d2a4050843@linaro.org> <20230906093531.GO7971@pendragon.ideasonboard.com> <169399810391.277971.691693692840899613@ping.linuxembedded.co.uk> <20230906111429.GC17308@pendragon.ideasonboard.com> <20230907150408.GC17610@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230907150408.GC17610@pendragon.ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 07, 2023 at 06:04:09PM +0300, Laurent Pinchart wrote: > On Thu, Sep 07, 2023 at 11:55:13PM +0900, Paul Elder wrote: > > On Wed, Sep 06, 2023 at 02:14:29PM +0300, Laurent Pinchart wrote: > > > On Wed, Sep 06, 2023 at 12:01:43PM +0100, Kieran Bingham wrote: > > > > Quoting Laurent Pinchart (2023-09-06 10:35:31) > > > > > On Wed, Sep 06, 2023 at 11:21:31AM +0200, Krzysztof Kozlowski wrote: > > > > > > On 06/09/2023 11:00, Laurent Pinchart wrote: > > > > > > >>> has a regulator@0. There are similar instances for clocks. > > > > > > >>> > > > > > > >>> I understand why it may not be a good idea, and how the root node is > > > > > > >>> indeed not a bus. In some cases, those regulators and clocks are grouped > > > > > > >>> in a regulators or clocks node that has a "simple-bus" compatible. I'm > > > > > > >>> not sure if that's a good idea, but at least it should validate. > > > > > > >>> > > > > > > >>> What's the best practice for discrete board-level clocks and regulators > > > > > > >>> in overlays ? How do we ensure that their node name will not conflict > > > > > > >>> with the board to which the overlay is attached ? > > > > > > >> > > > > > > >> Top-level nodes (so under /) do not have unit addresses. If they have - > > > > > > >> it's an error, because it is not a bus. Also, unit address requires reg. > > > > > > >> No reg? No unit address. DTC reports this as warnings as well. > > > > > > > > > > > > > > I agree with all that, but what's the recommended practice to add > > > > > > > top-level clocks and regulators in overlays, in a way that avoids > > > > > > > namespace clashes with the base board ? > > > > > > > > > > > > Whether you use regulator@0 or regulator-0, you have the same chances of > > > > > > clash. > > > > > > > > > > No disagreement there. My question is whether there's a recommended > > > > > practice to avoid clashes, or if it's an unsolved problem that gets > > > > > ignored for now because there's only 36h in a day and there are more > > > > > urgent things to do. > > > > > > > > Should an overlay add these items to a simple-bus specific to that > > > > overlay/device that is being supported? > > > > > > > > That would 'namespace' the added fixed-clocks/fixed-regulators etc... > > > > > > > > But maybe it's overengineering or mis-using the simple-bus. > > > > > > You would still need to name the node that groups the regulators and > > > clocks in a way that wouldn't clash between multiple overlays and the > > > base board. It would be nice to have nodes that are "private" to an > > > overlay. > > > > What's the best solution to this then :/ > > It seems we don't have a good solution. For now, I'd recommend just > picking a name for the regulator that has a high chance to be unique, > like reg-thp7312-1v2 for instance. Or reg-cam-1v2, or ... The name doesn't matter much really, as long as it's not extremely generic with a high risk of conflict. > > > > And the items are still not on a 'bus' with an address - they just exist > > > > on a presumably externally provided board.... -- Regards, Laurent Pinchart